2091928 - [wpt-sync] Sync PR 64545 - [style] Revert "Remove unused RuleSetFlag"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 64545 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64545
Details from upstream follow.

Eldar Pulatov <[e-mail]> wrote:

[style] Revert "Remove unused RuleSetFlag"

This reverts commit fd68a40ff06ab39fc5b96f99a2c26a53de4395ea. Original
CL: https://crrev.com/c/5153352

Layer-order changes request kFullRecalcRules through kRuleSetFlagsAll.
Removing the flag and its handler left computed styles stale when layer
declarations changed the winning rules in unchanged sheets.

Restore the flag in an unused bit to preserve the current numbering. Add
regression tests and document why the all-flags value requests subtree
style recalc.

Bug: 570832596
Change-Id: Idb846018d04c9b7fdd705b114d0988843aff6594
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8564519
Reviewed-by: Rune Lillesveen \<[e-mail]>
Commit-Queue: Eldar Pulatov \<[e-mail]>
Reviewed-by: Daniil Sakhapov \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1732761}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=118809

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 165 tests

Status Summary

Firefox

OK : 1[GitHub] 108[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 3[GitHub] 7[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1663[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1703[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 1710[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 20[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 23[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 1
FAIL: 3

Safari

OK : 1
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-cascade/declaration-context.html [wpt.fyi]
  • @page inside @scope accepts page declarations: FAIL
• /css/css-cascade/presentational-hints-rollback.html [wpt.fyi]
  • #tests > * 7: FAIL
  • #tests > * 15: FAIL
• /css/css-cascade/revert-rule-cycle.tentative.html [wpt.fyi]
  • Cycle between revert-rule !important and revert-layer resolves to unset instead of lower layers: FAIL
  • Multi-layer chain cycle with revert-rule !important resolves to unset instead of lower layers: FAIL
• /css/css-cascade/revert-val-006.html [wpt.fyi]
  • The revert keyword works with @keyframes: FAIL
• /css/css-cascade/revert-val-007.html [wpt.fyi]
  • A @keyframe animation with revert works when applied to multiple identical elements: FAIL
• /css/css-cascade/revert-val-008.html [wpt.fyi]
  • The revert keyword works in the final frame of a web animation: FAIL
• /css/css-cascade/revert-val-010.html [wpt.fyi]
  • The revert works when appearing in setKeyframes: FAIL
• /css/css-cascade/scope-deep.html [wpt.fyi]
  • Deep @scope nesting: FAIL
• /css/css-cascade/scope-implicit-constructed-document.html [wpt.fyi]
  • Implicit @scope in a constructed stylesheet adopted by a document matches the root element: FAIL
  • Child combinator in implicit @scope in a constructed stylesheet adopted by a document matches only the root element: FAIL
• /css/css-cascade/scope-import-implicit.html [wpt.fyi]
  • Scope-imported rule applies within implicit scope: FAIL
• /css/css-cascade/scope-import-inner-scope.html [wpt.fyi]
  • @scope within scope-imported stylesheet matches: FAIL
• /css/css-cascade/scope-import-multiple.html [wpt.fyi]
  • A stylesheet may be imported multiple times, and scoped differently: FAIL
• /css/css-cascade/scope-import-parent-pseudo.html [wpt.fyi]
  • The & selector matches the scoping root: FAIL
  • The & selector behaves like :scope: FAIL
• /css/css-cascade/scope-import-scope-end.html [wpt.fyi]
  • Scope-imported rule applies within scope, above limit: FAIL
• /css/css-cascade/scope-import-scope-pseudo.html [wpt.fyi]
  • The :scope pseudo-class works in imported stylesheets: FAIL
• /css/css-cascade/scope-import-scope-start.html [wpt.fyi]
  • Scope-imported rule applies within scope: FAIL
• /css/css-cascade/all-prop-initial-visited.html [wpt.fyi]: FAIL
• /css/css-cascade/revert-layer-010.html [wpt.fyi]: FAIL
• /css/css-cascade/scope-visited.html [wpt.fyi]: FAIL

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0f1b131a231e
https://hg.mozilla.org/integration/autoland/rev/64c491407243
[wpt PR 64545] - [style] Revert "Remove unused RuleSetFlag", a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/64c491407243