Closed Bug 2091959 Opened 3 days ago Closed 11 hours ago

[wpt-sync] Sync PR 64552 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=311552

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
162 Branch
Tracking Flags:
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64552 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64552
Details from upstream follow.

Sean Patterson <sean_patterson@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=311552

WebKit export from bug: [<!---->SVG2]<!----> remove use-<!---->script,<!----> no-<!---->change,<!----> reset-<!---->size from dominant-<!---->baseline

<pre>
[SVG2] Remove use-script, no-change and reset-size from dominant-baseline

SVG 2 no longer supports the use-script, no-change and reset-size values of
dominant-baseline [1], and they are absent from the css-inline-3 grammar that
now defines the property [2].

All three were already close to no-ops in WebKit: use-script mapped to
alphabetic behind a FIXME, while no-change and reset-size deferred to the
parent element's dominant baseline, which resolves to alphabetic for
horizontal text. Removing them lets the values fall back to auto, which maps
to alphabetic in horizontal writing modes and central in vertical ones, so
there is no rendering change for the cases these values previously covered.

svg/custom/dominant-baseline-modes.svg and svg/custom/alignment-baseline-modes.svg
continue to specify the three values, which now fall back to auto; their
results are unchanged for the reason above.

Note that WebKit still spells the two edge baselines with their SVG 1.1 names,
text-before-edge and text-after-edge. css-inline-3 renames those to text-top
and text-bottom and keeps the SVG spellings only as legacy aliases [3], and
WebKit does not yet accept the css-inline-3 names. That gap is orthogonal to
this patch, which only removes values; it is tracked separately in
webkit.org/b/321612.

[1] <a href="https://w3c.github.io/svgwg/svg2-draft/text.html#DominantBaselineProperty">https://w3c.github.io/svgwg/svg2-draft/text.html#DominantBaselineProperty</a>
[2] <a href="https://drafts.csswg.org/css-inline-3/#propdef-dominant-baseline">https://drafts.csswg.org/css-inline-3/#propdef-dominant-baseline</a>
[3] <a href="https://drafts.csswg.org/css-inline/#alignment-baseline-svg-legacy">https://drafts.csswg.org/css-inline/#alignment-baseline-svg-legacy</a>

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=311552">https://bugs.webkit.org/show_bug.cgi?id=311552</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/319256@main">https://commits.webkit.org/319256@main</a>
</pre>

Component: web-platform-tests → SVG
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 137 tests

Status Summary

Firefox

OK : 1[GitHub] 42[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 3[GitHub] 7[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 176[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 242[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 243[Gecko-windows11-64-25h2-debug] 244[Gecko-windows11-64-25h2-opt] 245[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 21[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 40[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 41[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 43[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]

Chrome

OK : 1
FAIL: 3

Safari

OK : 1
PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

  • /svg/text/reftests/transform-dynamic-change.html [wpt.fyi]: PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-opt], SKIP [Gecko-windows11-64-25h2-debug]

https://hg.mozilla.org/mozilla-central/rev/7676c3886f74

Status: NEW → RESOLVED
Closed: 11 hours ago
status-firefox162: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.