Open Bug 2092011 Opened 3 days ago Updated 3 days ago

[customizable-menu] Show the section reordering actions in a bottom sheet on long press of the drag handle

Categories

(Firefox for Android :: Menu, task)

All
Android
task

Tracking

()

ASSIGNED

People

(Reporter: petru, Assigned: petru)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][android-core])

Attachments

(4 external files)

Consult Figma for up-to-date specs.

In the "Customize menu" screen, long pressing a section's drag handle should open a bottom sheet with the same actions TalkBack offers for that section (added in bug 2086547):

  • shown sections: "Move up", "Move down", "Hide section";
  • hidden sections: "Unhide section".

Behaviour:

  • "Hide section" adds the section at the top of the hidden sections, "Unhide section" at the bottom of the shown ones (as the TalkBack actions do).
  • "Move up" is disabled for the first section and "Move down" for the last one.
  • The sheet is dismissed by tapping outside it, swiping down its handle, or going back.
  • The menu section should be highlighted to be clear what element the buttons from the bottom sheet operates on
  • If a long press on the handle opens the bottom sheet then the user should not be able to drag the menu section by dragging on the screen with the finger.

Notes:

  • The drag handle starts dragging as soon as the finger moves vertically, so a long press without moving is free for this. The rest of the section starts dragging after a long press, so the sheet only opens from the handle.

Updates approved by Aarjav:

  • the actions name will be updated to ensure the same between Talkback and the new bottomsheet
  • it’s okay for Talkback to hide actions which are not available and the bottom sheet to show them as disabled - similar to how they might look in the menu
  • inside “Hidden sections” there should be no option to move sections up/down - for both Talkback and the new bottom sheet
  • since “Accounts and settings” can’t be hidden.“Hide section” should not be shown/shown as disabled
  • anytime the user taps (short/long) outside the bottom sheet we should close it, similar to how the menu functions.
Assignee: nobody → petru
Status: NEW → ASSIGNED
See Also: → 2092153

The actions TalkBack offers for a section are now listed in one place, with the
ones which cannot apply kept as such, for the actions sheet of part 3 to
show the same ones.

As already done for the hidden sections title, for the list to stay short enough
once it also shows the actions sheet of a section.

Long pressing the drag handle of a section opens a bottom sheet with Move up,
Move down, and Hide for a shown section or Unhide for a hidden one, the actions
TalkBack offers for it. Unlike TalkBack, which leaves them out, the sheet shows
the actions which cannot apply disabled, as the main menu does.

The sheet opens as soon as the press is a long press, as other long press
popups do, and the rest of that touch no longer drags the section.

While its actions sheet is open, a section is shown as in the design: filled
and outlined, for it to be clear what the actions apply to.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: