2092282 - [wpt-sync] Sync PR 64551 - [XSLT] Fix crash for xsl:import/xsl:include without href

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 64551 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64551
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

[XSLT] Fix crash for xsl:import/xsl:include without href

XSLStyleSheet::LoadChildSheets() passed the result of xsltGetNsProp()
for the href attribute directly to String::FromUtf8(). When the
attribute is missing, xsltGetNsProp() returns null, and converting that
null pointer to std::string_view trips a libc++ hardening assertion,
crashing the renderer.

This CL skips loading a child sheet when href is absent. libxslt still
reports the missing attribute when it compiles the stylesheet.

Fixed: 566820671
Change-Id: I93a86c611cb8b2fd3d4f20da644b19e2eaebdc01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8693277
Auto-Submit: Mason Freed \<[e-mail]>
Commit-Queue: Joey Arhar \<[e-mail]>
Reviewed-by: Joey Arhar \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1732853}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=118958

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 18 tests and 5 subtests

Status Summary

Firefox

OK : 6
PASS: 1[GitHub] 9[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 204[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 206[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 2[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 3[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /xml/xslt/encoding-single-chunk.html [wpt.fyi]: FAIL
• /xml/xslt/functions.tentative.window.html [wpt.fyi]
  • unparsed-entity-uri: FAIL
• /xml/xslt/fetch/xslt.https.sub.html [wpt.fyi]
  • undefined: sec-fetch-mode: FAIL

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5414061d89de
https://hg.mozilla.org/integration/autoland/rev/a512276cf386
[wpt PR 64551] - [XSLT] Fix crash for xsl:import/xsl:include without href, a=testonly
https://github.com/mozilla-firefox/firefox/commit/3c22700b8dd1
https://hg.mozilla.org/integration/autoland/rev/12a0650c7c6c
[wpt PR 64551] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a512276cf386
https://hg.mozilla.org/mozilla-central/rev/12a0650c7c6c