Closed Bug 2092409 Opened 2 days ago Closed 11 hours ago

[wpt-sync] Sync PR 64555 - Fix CSSOM gap serialization with mixed initial values

Categories

(Core :: Layout: Block and Inline, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64555 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64555
Details from upstream follow.

Aakash <aaka3h@gmail.com> wrote:

Fix CSSOM gap serialization with mixed initial values

Do not combine a mixed initial gap longhand and a length into an invalid
shorthand. Preserve both longhand declarations so cssText round-trips
without losing layout.

Add WPT coverage for both mixed orders, importance, live style rules,
and valid gap shorthand and alias controls.

Bug: 578577128
Change-Id: I666b1318b2809751b87a2709c64db055b74eab16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8668481
Reviewed-by: Helmut Januschka \<helmut@januschka.com>
Commit-Queue: Helmut Januschka \<helmut@januschka.com>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1732877}

Component: web-platform-tests → Layout: Block and Inline
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 22 tests and 18 subtests

Status Summary

Firefox

OK : 1[GitHub] 20[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 3[GitHub] 162[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 164[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 1
PASS: 2
FAIL: 1

Safari

OK : 1
PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1698eb1e01ba https://hg.mozilla.org/integration/autoland/rev/738393ff0b4b [wpt PR 64555] - Fix CSSOM gap serialization with mixed initial values, a=testonly
Status: NEW → RESOLVED
Closed: 11 hours ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.