[wpt-sync] Sync PR 64560 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=285130
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64560 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64560
Details from upstream follow.
Ahmad Saleem <ahmad.saleem792+github@gmail.com> wrote:
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=285130
WebKit export from bug: insertRule does not work for inserting @<!---->scope styles
<pre>
insertRule does not work for inserting @scope stylesThis patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
An @scope rule without a prelude finds its scoping root through
StyleRuleScope::m_styleSheetOwner, a weak pointer to the owning
StyleSheetContents. That pointer was stale in two cases:
- CSSStyleSheet::insertRule() parses the rule against m_contents before
RuleMutationScope runs willMutateRules(). Inline <style> sheets are
cached and shared, so the first mutation clones the contents, and the
new rule's owner pointed at the old, client-less contents. No scoping
root was found and the rule never matched. CSSGroupingRule::insertRule()
and CSSStyleRule::insertRule() had the same ordering problem.- StyleRuleScope's copy constructor is defaulted, so the copies made by
the StyleSheetContents copy constructor kept pointing at the original
contents.Add StyleSheetContents::adoptScopeRules(), which recursively re-points
@scope rules (including ones nested in style and grouping rules) at the
given contents. Call it from the copy constructor, wrapperInsertRule(),
and the nested insertRule() paths.WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=285130">https://bugs.webkit.org/show_bug.cgi?id=285130</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/325468@main">https://commits.webkit.org/325468@main</a>
</pre>
| Assignee | ||
Updated•3 days ago
|
| Assignee | ||
Comment 1•3 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=119211
| Assignee | ||
Comment 2•3 days ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 165 tests
Status Summary
Firefox
OK : 1[GitHub] 108[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 5[GitHub] 7[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1665[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1705[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 1712[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 20[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 23[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
OK : 1
PASS: 5
Safari
OK : 1
PASS: 2
FAIL: 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-cascade/all-prop-initial-visited.html [wpt.fyi]:
FAIL - /css/css-cascade/revert-layer-010.html [wpt.fyi]:
FAIL - /css/css-cascade/scope-visited.html [wpt.fyi]:
FAIL - /css/css-cascade/declaration-context.html [wpt.fyi]
- @page inside @scope accepts page declarations:
FAIL
- @page inside @scope accepts page declarations:
- /css/css-cascade/presentational-hints-rollback.html [wpt.fyi]
- #tests > * 7:
FAIL - #tests > * 15:
FAIL
- #tests > * 7:
- /css/css-cascade/revert-rule-cycle.tentative.html [wpt.fyi]
- Cycle between revert-rule !important and revert-layer resolves to unset instead of lower layers:
FAIL - Multi-layer chain cycle with revert-rule !important resolves to unset instead of lower layers:
FAIL
- Cycle between revert-rule !important and revert-layer resolves to unset instead of lower layers:
- /css/css-cascade/revert-val-006.html [wpt.fyi]
- The revert keyword works with @keyframes:
FAIL
- The revert keyword works with @keyframes:
- /css/css-cascade/revert-val-007.html [wpt.fyi]
- A @keyframe animation with revert works when applied to multiple identical elements:
FAIL
- A @keyframe animation with revert works when applied to multiple identical elements:
- /css/css-cascade/revert-val-008.html [wpt.fyi]
- The revert keyword works in the final frame of a web animation:
FAIL
- The revert keyword works in the final frame of a web animation:
- /css/css-cascade/revert-val-010.html [wpt.fyi]
- The revert works when appearing in setKeyframes:
FAIL
- The revert works when appearing in setKeyframes:
- /css/css-cascade/scope-deep.html [wpt.fyi]
- Deep @scope nesting:
FAIL
- Deep @scope nesting:
- /css/css-cascade/scope-implicit-constructed-document.html [wpt.fyi]
- Implicit @scope in a constructed stylesheet adopted by a document matches the root element:
FAIL - Child combinator in implicit @scope in a constructed stylesheet adopted by a document matches only the root element:
FAIL
- Implicit @scope in a constructed stylesheet adopted by a document matches the root element:
- /css/css-cascade/scope-import-implicit.html [wpt.fyi]
- Scope-imported rule applies within implicit scope:
FAIL
- Scope-imported rule applies within implicit scope:
- /css/css-cascade/scope-import-inner-scope.html [wpt.fyi]
- @scope within scope-imported stylesheet matches:
FAIL
- @scope within scope-imported stylesheet matches:
- /css/css-cascade/scope-import-multiple.html [wpt.fyi]
- A stylesheet may be imported multiple times, and scoped differently:
FAIL
- A stylesheet may be imported multiple times, and scoped differently:
- /css/css-cascade/scope-import-parent-pseudo.html [wpt.fyi]
- The & selector matches the scoping root:
FAIL - The & selector behaves like :scope:
FAIL
- The & selector matches the scoping root:
- /css/css-cascade/scope-import-scope-end.html [wpt.fyi]
- Scope-imported rule applies within scope, above limit:
FAIL
- Scope-imported rule applies within scope, above limit:
- /css/css-cascade/scope-import-scope-pseudo.html [wpt.fyi]
- The :scope pseudo-class works in imported stylesheets:
FAIL
- The :scope pseudo-class works in imported stylesheets:
- /css/css-cascade/scope-import-scope-start.html [wpt.fyi]
- Scope-imported rule applies within scope:
FAIL
- Scope-imported rule applies within scope:
Comment 4•1 day ago
|
||
| bugherder | ||
Description
•