Closed Bug 2092418 Opened 3 days ago Closed 1 day ago

[wpt-sync] Sync PR 64562 - Shared Storage: Remove fenced frame reporting and attestations

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64562 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64562
Details from upstream follow.

Camillia Smith Barnes <cammie@chromium.org> wrote:

Shared Storage: Remove fenced frame reporting and attestations

Remove unused Shared Storage fenced frame reporting support and
Privacy Sandbox attestations enum values:

  • Remove FencedFrameReporter::CreateForSharedStorage. Because
    FencedFrameReporter::CreateForFledge and its tests were already
    removed when Protected Audience was disconnected from the build
    (https://crrev.com/c/8092390), CreateForSharedStorage was the last
    remaining FencedFrameReporter factory method. Delete
    fenced_frame_reporter_unittest.cc (whose remaining tests all called
    CreateForSharedStorage) and the ReportingMetadataSuccess test in
    fenced_frame_url_mapping_unittest.cc (since FencedFrameReporter can
    no longer be instantiated).
  • Remove kSharedStorageSelectUrl from ReportingDestination in mojom,
    blink::FencedFrame, and mojom traits.
  • Remove kSharedStorage from
    privacy_sandbox::PrivacySandboxAttestationsGatedAPI, reserve
    SHARED_STORAGE in privacy_sandbox_attestations.proto, and remove
    content::PrivacySandboxInvokingAPI entirely.
  • Remove the invoking_api parameter from
    PrivacySandboxSettings::IsEventReportingDestinationAttested,
    ContentBrowserClient::IsPrivacySandboxReportingDestinationAttested,
    and FencedFrameReporter.
  • Update stale comments in FencedFrameReporter, fenced frame mojom,
    and WPT helpers.

Bug: 462465887
Change-Id: I4d09d4d055d4d18081738142362b435e3ceeb08f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8635309
Reviewed-by: Dmitry Gozman \<dgozman@chromium.org>
Reviewed-by: Ken Buchanan \<kenrb@chromium.org>
Reviewed-by: Kevin Graney \<kmg@google.com>
Commit-Queue: Cammie Smith Barnes \<cammie@chromium.org>
Reviewed-by: Xiaochen Zhou \<xiaochenzh@chromium.org>
Auto-Submit: Cammie Smith Barnes \<cammie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1733013}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 1 subtests

Status Summary

Firefox

OK : 7
PASS: 5
FAIL: 11

Chrome

OK : 7
PASS: 5
FAIL: 11

Safari

OK : 7
PASS: 4
FAIL: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /fenced-frame/add-fencedframe-to-detached-iframe.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
  • /fenced-frame/fenced-frame-stub.https.html [wpt.fyi]: SKIP
  • /fenced-frame/intersection-observer.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
    • Intersection Observer Test: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fenced-frame/key-value-store.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
  • /fenced-frame/parse-from-string-sandboxed-iframe.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
  • /fenced-frame/script-focus.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
    • An embedder can focus out of a fenced frame: FAIL (Chrome: FAIL, Safari: FAIL)
    • Fenced frames can't pull script focus until getting user activation: FAIL (Chrome: FAIL, Safari: FAIL)
    • Focused fenced frames can move programmatic focus within frame: FAIL (Chrome: FAIL, Safari: FAIL)
    • Script focus into a fenced frame consumes user activation: FAIL (Chrome: FAIL, Safari: FAIL)
    • Another fenced frame cannot pull focus out of a focused fenced frame: FAIL (Chrome: FAIL, Safari: FAIL)
    • A fenced frame nested in another fenced frame cannot pull focus: FAIL (Chrome: FAIL, Safari: FAIL)
    • A fenced frame cannot pull window.focus() without user activation: FAIL (Chrome: FAIL, Safari: FAIL)
    • A fenced frame can pull window.focus() after user activation: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fenced-frame/setting-null-config-navigates-to-about-blank.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
    • Test that a fenced frame with a config explicitly set to null navigates to about:blank: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fenced-frame/subframe-loading.https.html [wpt.fyi]: SKIP
  • /fenced-frame/user-activation.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
    • user-activation: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

  • /fenced-frame/add-fencedframe-to-detached-iframe.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
  • /fenced-frame/fenced-frame-stub.https.html [wpt.fyi]: SKIP
  • /fenced-frame/intersection-observer.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
  • /fenced-frame/key-value-store.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
  • /fenced-frame/parse-from-string-sandboxed-iframe.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
  • /fenced-frame/script-focus.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
  • /fenced-frame/setting-null-config-navigates-to-about-blank.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
  • /fenced-frame/subframe-loading.https.html [wpt.fyi]: SKIP
  • /fenced-frame/user-activation.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0d77d74d997a https://hg.mozilla.org/integration/autoland/rev/f880c795676e [wpt PR 64562] - Shared Storage: Remove fenced frame reporting and attestations, a=testonly
Status: NEW → RESOLVED
Closed: 1 day ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.