Closed Bug 2092429 Opened 4 days ago Closed 2 days ago

[wpt-sync] Sync PR 64566 - Add missing step_func()s in switch_reentrant_removal.html

Categories

(Core :: SVG, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64566 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64566
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Add missing step_func()s in switch_reentrant_removal.html

If an assertion fails (like it does in Blink currently), the exception
will cause a harness error and a timeout. Wrap the event listeners in
step_func() to avoid this. Use a step_func_done() to eliminate the
explicit t.done().

Bug: 579016294
Change-Id: I04cf160f73b16cceea986d8c7ff8511818ae95e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8706012
Commit-Queue: Philip Rogers \<pdr@chromium.org>
Auto-Submit: Fredrik Söderquist \<fs@opera.com>
Reviewed-by: Philip Rogers \<pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1733072}

Component: web-platform-tests → SVG
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 25 tests and 6 subtests

Status Summary

Firefox

OK : 1[GitHub] 23[Gecko-windows11-32-25h2-opt] 24[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 1[GitHub] 50[Gecko-windows11-32-25h2-opt] 53[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 7

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/59d98a65cfd7 https://hg.mozilla.org/integration/autoland/rev/925ddaeb96ba [wpt PR 64566] - Add missing step_func()s in switch_reentrant_removal.html, a=testonly
Status: NEW → RESOLVED
Closed: 2 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.