Open
Bug 2092650
Opened 5 days ago
Updated 5 days ago
record smart actions toolbar searches with their own search access point
Categories
(Core :: Machine Learning: Frontend, enhancement)
Core
Machine Learning: Frontend
Tracking
()
NEW
People
(Reporter: Mardak, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [aiasst])
The search action from bug 2091509 runs AIWindow.performSearch, which always passes sapSource: "smartwindow_assistant" to SearchUIUtils.loadSearch. A search from the smart actions toolbar is therefore counted as a search from the Smart Window assistant, and the two cannot be told apart. Raised in review of D342411.
Toolbar searches should get their own access point, for example actions_toolbar:
- let
performSearchtake the source from its caller, keepingsmartwindow_assistantfor the existing assistant callers inTools.sys.mjs, and pass the new source fromsearchActioninSmartActionsToolbar.sys.mjs - add the source to
KNOWN_SEARCH_SOURCESinBrowserSearchTelemetry.sys.mjs - add it to the lists of possible
sourcevalues inbrowser/components/search/metrics.yaml, plus abrowser.engagement.navigationlabeled counter like the existingsmartwindow_assistantone if the per-source counter is wanted - document it in
browser/components/search/docs/telemetry.md
These metrics are reported to the search telemetry and revenue data owners (fx-search-telemetry@mozilla.com, rev-data@mozilla.com), so the patch needs review from the search team and a data review.
performSearch also focuses the Smart Window sidebar after the search when it is open, which may not be wanted after clicking a toolbar button.
Updated•5 days ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•