Open Bug 2092650 Opened 5 days ago Updated 5 days ago

record smart actions toolbar searches with their own search access point

Categories

(Core :: Machine Learning: Frontend, enhancement)

enhancement
Points:
2

Tracking

()

People

(Reporter: Mardak, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [aiasst])

The search action from bug 2091509 runs AIWindow.performSearch, which always passes sapSource: "smartwindow_assistant" to SearchUIUtils.loadSearch. A search from the smart actions toolbar is therefore counted as a search from the Smart Window assistant, and the two cannot be told apart. Raised in review of D342411.

Toolbar searches should get their own access point, for example actions_toolbar:

  • let performSearch take the source from its caller, keeping smartwindow_assistant for the existing assistant callers in Tools.sys.mjs, and pass the new source from searchAction in SmartActionsToolbar.sys.mjs
  • add the source to KNOWN_SEARCH_SOURCES in BrowserSearchTelemetry.sys.mjs
  • add it to the lists of possible source values in browser/components/search/metrics.yaml, plus a browser.engagement.navigation labeled counter like the existing smartwindow_assistant one if the per-source counter is wanted
  • document it in browser/components/search/docs/telemetry.md

These metrics are reported to the search telemetry and revenue data owners (fx-search-telemetry@mozilla.com, rev-data@mozilla.com), so the patch needs review from the search team and a data review.

performSearch also focuses the Smart Window sidebar after the search when it is open, which may not be wanted after clicking a toolbar button.

You need to log in before you can comment on or make changes to this bug.