Closed Bug 2092659 Opened 5 days ago Closed 2 days ago

[Horoscopes] Date/sign selection menu is not usable at medium widget size

Categories

(Firefox :: New Tab Page, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 2090232

People

(Reporter: gharp, Unassigned)

References

(Blocks 1 open bug)

Details

Setup:
To enable the Horoscopes widget, set the following prefs to true

  • browser.newtabpage.activity-stream.widgets.system.horoscopes.enabled
    
  • browser.newtabpage.activity-stream.widgets.horoscopes.enabled
    

STR:

  1. Enable the Horoscopes widget
    
  2. Change widget size to "medium" (if not already medium)
    
  3. Click on the date /sign selection dropdown to open the menu
    
  4. Expected: The menu should be visible/navigable
    
  5. Actual: The menu is too small to be displayed in the medium-sized widget
    

Proposed solution to be explored by partner: Date selection CTA in medium size automatically expands widget to large size (with selection menu open?)

Possible duplicate: bug 2090232

The date/sign dropdown is drawn by the partner document inside the .horoscopes-frame iframe, so at medium size it is clipped to the iframe's bounds. Horoscopes.jsx also cannot grow on request: it has no iframe ref and never listens for the frame's change_size action, unlike Travel.jsx, which handles it through useFramedWidgetSize in useFramedWidgetMessages.jsx.

Fix: Port the Travel approach from bug 2089616: add a ref to the iframe, call useFramedWidgetSize, render with displaySize = widgetsMayBeMaximized && requestedSize ? requestedSize : widgetSize (className, telemetry, WidgetMenuFooter and SizeSubmenu), and call clearRequestedSize() in handleChangeSize, with tests in Horoscopes.test.jsx mirroring the resize cases in Travel.test.jsx. The partner page then has to post {channel: "horoscopes_widget", type: "action", message: "change_size", payload: {size: "large"}} when the selector opens, and size: "medium" to shrink back.

Suggested severity: S3. The sign/date selector is unusable at medium, which is the widget's default size, but switching the widget to large from its context menu works around it.


If you'd like to provide feedback on this comment, please use the 👍 or 👎 reaction.
If you want to categorize your feedback you can add one of the following tags: ai-triage-{wrong-file, wrong-cause, hallucination, out-of-scope, not-a-bug, wrong-fix, shallow-fix, wrong-severity}.

Needinfo hackbot@mozilla.tld to have a patch generated for this bug, include any questions or directions as needed in your comment.

Status: NEW → RESOLVED
Closed: 2 days ago
Duplicate of bug: 2090232
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.