fix warning in +mailnews/base/src/nsMsgFolderCompactor.cpp:557

RESOLVED FIXED

Status

MailNews Core
Backend
RESOLVED FIXED
15 years ago
9 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

15 years ago
+mailnews/base/src/nsMsgFolderCompactor.cpp:557
+ `PRUint32 writeCount' might be used uninitialized in this function

Updated

15 years ago
Blocks: 59652, 59673
OS: Windows 2000 → All
Product: MailNews → Core

Comment 1

13 years ago
When looking at this code, it seems to me that writeCount can't really be used
uninitialized (else the assertion will fail). But I don't think it would hurt us
that much to initialize the variables at the beginning of the while-loop as this
shouldn't be a really big performance problem, and it would safe us from
possible mistakes made in future. Also, why don't we move the variables inside
the while? For me, that would work the same, but it looks cleaner to me.
writeCount gets initialized with 0 in http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/base/src/nsMsgFolderCompactor.cpp&rev=1.78#647

This line was introduced by the patch for bug 114656, so this bug can be resolved fix.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.