209335 - fix warning in +mailnews/base/src/nsMsgFolderCompactor.cpp:557

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

+mailnews/base/src/nsMsgFolderCompactor.cpp:557
+ `PRUint32 writeCount' might be used uninitialized in this function

Comment 1

[Daniel Kraft]

When looking at this code, it seems to me that writeCount can't really be used
uninitialized (else the assertion will fail). But I don't think it would hurt us
that much to initialize the variables at the beginning of the while-loop as this
shouldn't be a really big performance problem, and it would safe us from
possible mistakes made in future. Also, why don't we move the variables inside
the while? For me, that would work the same, but it looks cleaner to me.

Comment 2

[Bruno 'Aqualon' Escherl]

writeCount gets initialized with 0 in http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/base/src/nsMsgFolderCompactor.cpp&rev=1.78#647

This line was introduced by the patch for bug 114656, so this bug can be resolved fix.