Rename Nova variables to remove Nova references in browser-sync.js
Categories
(Firefox :: Firefox Accounts, task, P3)
Tracking
()
People
(Reporter: nsharpley, Assigned: jreitano, Mentored, NeedInfo)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Remove references to Nova by renaming variables in browser/base/content/browser-sync.js.
Updated•1 day ago
|
Updated•1 day ago
|
| Assignee | ||
Updated•1 day ago
|
Updated•1 day ago
|
| Assignee | ||
Comment 1•1 day ago
|
||
Hi Sara, do you know how I can get access to that jira link? (https://mozilla-hub.atlassian.net/browse/FIDEFE-9786)
| Reporter | ||
Comment 2•14 hours ago
|
||
Hi John, thanks for picking this up! I don't think there's any extra information in the Jira link. Basically we want to drop any "nova" references in browser/base/content/browser-sync.js. We just need to rename the variables and l10n references to exclude "nova" in the name. Please let me know if you need any more guidance! I'm also available on Slack.
Updated•13 hours ago
|
| Assignee | ||
Comment 3•9 hours ago
•
|
||
Hi Nikki, I have a question about the scope. Only two of the Nova references in browser-sync.js are variables. There are also a couple other items that could be fixed the element id appMenu-nova-fxa-label (also referenced in a few other files) and the Fluent id appmenu-nova-fxa-sign-in in appmenu.ftl.
Wondering if I should rename only the two variables, or also rename those ids and add a migration recipe so existing translations carry over. The bigger fix removes every Nova reference from browser-sync.js, touches about 7 files and needs Fluent review. I can do either approach. What do you think?
Description
•