Open Bug 2093948 Opened 2 hours ago

Tooltips show empty parentheses, such as "Reload current page ()", after a shortcut is cleared in about:keyboard

Categories

(Firefox :: Keyboard Navigation, defect)

defect

Tracking

()

ASSIGNED

People

(Reporter: spohl, Assigned: spohl)

References

Details

When a keyboard shortcut is cleared in about:keyboard, tooltips that include that shortcut show empty parentheses where the shortcut used to be.

Steps to reproduce:

  1. Open about:keyboard.
  2. In the first "Reload" row, click the "Clear" button.
  3. Open a new window and hover over the Reload button.

Expected results: "Reload current page"
Actual results: "Reload current page ()"

The shortcut is part of the localized string (reloadButton.tooltip is Reload current page (%S)), so fixing this needs a variant without the shortcut for each affected tooltip, used when the key has no shortcut. This affects the tooltips built by DynamicShortcutTooltip in browser.js (reload, stop, new tab, new window, downloads, full screen, zoom, reader view, bookmarks) and Fluent tooltips with a $shortcut argument, such as "Go back one page ()" and "Find in this page ()".

You need to log in before you can comment on or make changes to this bug.