Closed
Bug 2094356
Opened 2 days ago
Closed 1 day ago
Include interaction state with travel endpoint
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
162 Branch
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: maxx, Assigned: maxx)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [hnt][hnt-wattle])
Attachments
(1 external file)
Travel widget 1.5.0 (HNT-4142) moves its hero text down to clear the NEW badge, but only when Firefox tells it the badge is showing. Firefox does not send that today, so the badge overlaps the title on first use.
The widget expects an interaction_state message reflecting the widgets.travel.interaction pref
| Assignee | ||
Updated•2 days ago
|
Assignee: nobody → mcrawford
Whiteboard: [hnt][hnt-wattle]
Updated•2 days ago
|
| Assignee | ||
Comment 1•2 days ago
|
||
| Assignee | ||
Updated•2 days ago
|
Blocks: hnt-train-hop-160
Pushed by dgrant@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/630af3ada517
https://hg.mozilla.org/integration/autoland/rev/c7e9c8fc3ac3
Send the Travel widget frame an interaction_state action so it can move its hero text clear of the New badge. r=Dre
Pushed by abutkovits@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/8da3dde8632b
https://hg.mozilla.org/integration/autoland/rev/2d2a69dc3bb7
Revert "Bug 2094356 - Send the Travel widget frame an interaction_state action so it can move its hero text clear of the New badge. r=Dre" for causing failures at browser_framed_widgets.js.
Comment 4•2 days ago
|
||
Backed out for causing failures at browser_framed_widgets.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/2d2a69dc3bb7
Failure log: https://treeherder.mozilla.org/logviewer?job_id=608211226&repo=autoland&task=cmCJ1spfQUqdbZN-YvlPXg.0&lineNumber=3954
Flags: needinfo?(mcrawford)
Pushed by mcrawford@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/e9b4841cf68f
https://hg.mozilla.org/integration/autoland/rev/f5a2fb49b874
Send the Travel widget frame an interaction_state action so it can move its hero text clear of the New badge. r=Dre
Comment 7•1 day ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 day ago
status-firefox162:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•