Closed Bug 2094362 Opened 3 days ago Closed 3 days ago

Per-device sync: replace this device's tabs record with an empty one when Tab syncing is switched off

Categories

(Firefox :: Sync, task)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: skhamis, Assigned: skhamis)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsync-])

Attachments

(1 external file)

With per-device engine choices, unticking Tabs on one device doesn't turn tabs off for the account. That device's last uploaded tabs record stays on the server, so other devices keep showing those tabs.

Deleting the record doesn't fix this. Tabs readers (the a-s tabs component on Desktop, Android and iOS) fetch only records changed since their last sync and keep a local cache. A deleted record never shows up as changed, so other devices keep the stale tabs until the 180-day record TTL. Legacy clients can't be updated.

For future readers of PDS tabs, we will add a new field to the payload tabsDisabled: bool, this will allow us to have more control on whether we show other devices as connected but "no open tabs" or hide them completely.

Each device owns its own tabs record, keyed by its clients-record ID. So a device can safely overwrite it.

Whiteboard: [fxsync-]
Assignee: nobody → skhamis
Status: NEW → ASSIGNED
Pushed by skhamis@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/34882b1189e3 https://hg.mozilla.org/integration/autoland/rev/c236d3b2af01 replace device's tabs record with an empty when when tab syncing is turned off r=markh,sync-reviewers
Status: ASSIGNED → RESOLVED
Closed: 3 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch

What is the other field that's being discussed?

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: