Use {fmt} placeholders in the MSE duration overflow log messages
Categories
(Core :: Audio/Video: Playback, task)
Tracking
()
People
(Reporter: padenot, Unassigned, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=c++])
Two MSE_DEBUG calls in dom/media/mediasource/ use printf-style %s placeholders, but MSE_DEBUG in these files is defined on top of DDMOZ_LOG_FMT, which formats with {fmt} and expects {} placeholders. As a result the log line contains a literal "%s" and the TimeUnit value passed as an argument is never printed.
Other MSE_DEBUG calls in the same files already use {} and can serve as examples. Since the macro already prefixes each message with the function name, the function name at the start of these two messages can be dropped too.
Link to the code:
https://searchfox.org/firefox-main/rev/cac2c0cf44beecb92c93119bd79e2408636f76d7/dom/media/mediasource/MediaSource.cpp#625
https://searchfox.org/firefox-main/rev/cac2c0cf44beecb92c93119bd79e2408636f76d7/dom/media/mediasource/MediaSourceDecoder.cpp#271-272
Description
•