[test-verify] Remove the nofis variants on Android
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(firefox163 fixed)
| Tracking | Status | |
|---|---|---|
| firefox163 | --- | fixed |
People
(Reporter: owlish, Assigned: owlish)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][group6])
Attachments
(1 external file)
test-verify in taskcluster/kinds/test/misc.yml still runs without Fission on Android. It declares two variants:
variants:
- no-fission
- geckoview-isolated-process+no-fission
and schedules them on Android while disabling the Fission flavour:
no-fission:
by-test-platform:
...
android.*: [.integration.]
default: []
geckoview-isolated-process+no-fission:
by-test-platform:
android.*/debug: [.integration.]
default: []
default:
by-test-platform:
...
android.*: []
default: [.integration.]
Note the default branch sets android.*: [], so on Android test-verify runs only without Fission. The unvariant tasks are generated but never scheduled. Removing the no-fission entries alone would therefore delete Android test-verify coverage entirely rather than move it onto Fission.
The fix has the same shape as the webgl suites in bug 2078916: move the .integration. scheduling from no-fission into default, and convert geckoview-isolated-process+no-fission to plain geckoview-isolated-process.
Affected tasks, all on the x86_64 emulator, six platforms (ccov, lite, shippable, shippable-lite, debug, opt), with no hardware platforms involved:
test-android-em-14-x86_64-*/opt-geckoview-test-verify-nofis
test-android-em-14-x86_64-*/opt-geckoview-test-verify-isolated-nofis
Scheduling is .integration. rather than mozilla-central, and the task carries optimization: test-verify, so it only runs when relevant test files change. A scheduled-task count on any single push is therefore not a useful measure of the footprint.
Out of scope: test-verify-gpu in the same file declares no variants and is unaffected. test-coverage-wpt, which also still has Android no-fission tasks, lives in taskcluster/kinds/web-platform-tests/kind.yml and belongs with the web-platform-tests work.
With this and the web-platform-tests removal done, no Android task would use the no-fission variant, which is the precondition for dropping the android clause from the variant when condition in taskcluster/test_configs/variants.yml.
Precedents for the mechanics: bug 2079919 (reftest), bug 2078916 (mochitest), bug 2079921 (xpcshell, in review). Each also added a suite exclusion to the no-fission when clause so the tasks stop being generated rather than merely unscheduled.
| Assignee | ||
Updated•1 day ago
|
| Assignee | ||
Updated•1 day ago
|
| Assignee | ||
Updated•1 day ago
|
Updated•1 day ago
|
| Assignee | ||
Comment 1•17 hours ago
|
||
Updated•16 hours ago
|
Comment 3•3 hours ago
|
||
| bugherder | ||
Description
•