209733 - more efficient codepath for style changes on 'display: none' and descendant frames

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Right now we use ReconstructFramesForContent in a few places to handle the case
of a content node that *might* now need a new frame but currently doesn't have
one (i.e., it's 'display:none' or a descendant of something that's
'display:none' -- and in the latter case it definitely doesn't need a new
frame).  This is inefficient, because it does a bunch of notifications that
aren't needed.  Furthermore, it leaves a stale style context in the undisplayed
map, which shouldn't cause a problem now because the only case where that causes
a problem is where we do ReconstructStyleData(PR_TRUE) in the pres shell. 
However, it's worth fixing for that too so that we don't keep the undisplayed
map up-to-date 99% of the time, which could cause problems later.

Patch coming, once I extract it from a pile of other changes.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

(It's worth mentioning that another reason I want to do this is to remove an
optimization currently in nsXULElement.cpp that passes NS_STYLE_HINT_NONE as
the AttributeChanged hint.)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

The right patch this time, with the callers.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 125943 [details] [diff] [review]
patch

r+sr=me

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in, 2003-06-18 14:54 -0700.