210248 - os-specific.html 4.3.1.3.2: maybe missing a "my" before the line "$smtp_server = 'smtp.mycompany.com'; # change this" (The Bugzilla Guide - 2.17.4 Development Release)

Status: RESOLVED FIXED

(Bugzilla :: Documentation, defect)

Description

[Ning Cao]

User-Agent:       Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 5.0; YComp 5.0.2.6; .NET CLR 1.0.3705)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030507

in the document file of "The Bugzilla Guide - 2.17.4 Development Release" at 
http://www.bugzilla.org/docs/html/os-specific.html,
Chapter 4.3. OS Specific Installation Notes,
4.3.1.3.2. Changes to BugMail.pm,

The document said that the open(SENDMAIL... maybe replaced by the followng:

use Net::SMTP;
$smtp_server = 'smtp.mycompany.com';  # change this

# Use die on error, so that the mail will be in the 'unsent mails' and
... ...

It seems a "my" is missing before the second line.
It may be looks like:
my $smtp_server = 'smtp.mycompany.com';  # change this


The perl complains that 
undef error - Global symbol "$smtp_server" requires explicit package name at 
Bugzilla/BugMail.pm line 875. Global symbol "$smtp_server" requires explicit 
package name at Bugzilla/BugMail.pm line 879. Compilation failed in require at 
Bugzilla/Template.pm line 265.  
 
I use ActivePerl v5.6.1 build 635 and Net-SMTP-Multipart 1.5 on Win2k.



Reproducible: Always

Steps to Reproduce:
1. follow the steps in bugzilla-2.17.4 document 4.3.1.3.2
2.
3.

Actual Results:  
Mails could not be sent, errors are reported in red.

Internal Error  
    

Bugzilla has suffered an internal error. Please save this page and send it to 
[e-mail] with details of what you were doing at the time this message 
appeared. 

URL: http://127.0.0.1/bugzilla-2.17.4/post_bug.cgi

Comment 1

[Jean-Sebastien Guay]

Attachment: Patch to docs/xml/installation.xml

You're absolutely right. Here's the patch.

I can't assign the bug to myself, but this is the only thing needed...

Comment 2

[Jean-Sebastien Guay]

Comment on attachment 126289 [details] [diff] [review]
Patch to docs/xml/installation.xml

Requesting approval. Trivial change.

Comment 3

[Jacob Steenhagen]

-> Patch Author

Comment 4

[Jacob Steenhagen]

Checking in installation.xml;
/cvsroot/mozilla/webtools/bugzilla/docs/xml/installation.xml,v  <-- 
installation.xml
new revision: 1.48; previous revision: 1.47
done