210515 - Assertion in nsAccessible::GetFlatStringFromContentNode()

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

The assertion occurs if you try to do:
        textContent->CopyText(text);
when the text is of length 0

Comment 1

[Aaron Leventhal]

Attachment: Don't copy text if the textcontent is length 0

Comment 2

[Kyle Yuan]

Comment on attachment 126379 [details] [diff] [review]
Don't copy text if the textcontent is length 0

r=kyle

+	 if (text.Length()>0)
I prefer a space before & after operators.

Comment 3

[Aaron Leventhal]

Comment on attachment 126379 [details] [diff] [review]
Don't copy text if the textcontent is length 0

Thanks Kyle, I'll fix the spacing around the >

Comment 4

[[e-mail]]

Comment on attachment 126379 [details] [diff] [review]
Don't copy text if the textcontent is length 0

>       nsAutoString text;
This should have been moved inside the if block
>+      if (origLength > 0) {
>+        textContent->CopyText(text);
>+        text.CompressWhitespace();
>+        if (text.Length()>0)
This should have been fixed to !IsEmpty()
>+          aFlatString->Append(text);
>+        if (isHTMLBlock && !aFlatString->IsEmpty())
>+          aFlatString->Append(NS_LITERAL_STRING(" "));

Comment 5

[Aaron Leventhal]

Attachment: New patch with Neil's suggestions

Thanks Neil, good eyes.

Comment 6

[Aaron Leventhal]

Comment on attachment 126465 [details] [diff] [review]
New patch with Neil's suggestions

Carrying r=kyle

Comment 7

[Aaron Leventhal]

Comment on attachment 126379 [details] [diff] [review]
Don't copy text if the textcontent is length 0

sr= request is on newer patch now

Comment 8

[Alec Flett]

Comment on attachment 126465 [details] [diff] [review]
New patch with Neil's suggestions

sr=alecf
you could also sa aFlatString->Append(PRUnichar(' '); and get the same effect,
but take up 16 less bytes.

Comment 9

[timeless]

mozilla/accessible/src/base/nsAccessible.cpp 1.78