210556 - Should be able to serialize <li> in plaintext without the bullet characters added in.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

<ul><li> will always hit this bit of code in plaintext serialization:

768       static char bulletCharArray[] = "*o+#";
769       NS_ASSERTION(mULCount > 0, "mULCount should be greater than 0 here");
770       char bulletChar = bulletCharArray[(mULCount - 1) % 4];
771       mInIndentString.Append(PRUnichar(bulletChar));

This should not happen unless the caller cares about formatted output.  I
noticed this when implementing Node.textContent (see the DOM 3 core WD).  After
I do some testing to make sure this doesn't break things like plaintext editing,
I'll put out a patch.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: The smack down

Make OutputRaw do the right thing.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 126661 [details] [diff] [review]
The smack down

Wrong patch.  Sigh.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: The real patch

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 126662 [details] [diff] [review]
The real patch

Okay, so this makes raw mean raw.  This does not cause any regressions since
nobody is relying on raw output in the plaintext serializer (except
Node.textContent, which is the reason for this bug being filed).  I ran tests
against editor source view, dnd, copy, and mail plaintext view just to be sure
though, and everything seemed happy.

Comment 5

[harishd]

Comment on attachment 126662 [details] [diff] [review]
The real patch

Make sure that this patch does not break mail and news in the plain text mode.

r=harishd

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 126662 [details] [diff] [review]
The real patch

sr=jst

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Fix checked in 07/02/2003 17:34.