210639 - Confirm tab close ignores "Close Window".

Status: VERIFIED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Jason Bassford]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030625
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030625

The recently checked in fix for bug 108973, that throws up a confirmation
dialogue when closing a window with open tabs, works in every case (Exit, close
window button, etc.) except for when you choose File->Close Window (or
Ctrl-Shift-W).

Reproducible: Always

Steps to Reproduce:
1. Open multiple tabs.
2. Use File -> Close Window.
Actual Results:  
The window (with all open tabs) is closed without any confirmation.

Expected Results:  
The confirmation box should have been presented.

Comment 1

[Jason Bassford]

Adding Tim to CC list since he worked on the patch for bug 108973.

Comment 2

[Tim]

Attachment: Catch the last close method

grumble duplicated code grumble I wasn't observant enough grumble sorry

Comment 3

[Tim]

Comment on attachment 126477 [details] [diff] [review]
Catch the last close method

Sorry guys, I missed a code path. Can you spare a r+sr for a 2-liner?

Comment 4

[jag (Peter Annema)]

Comment on attachment 126477 [details] [diff] [review]
Catch the last close method

Nit: use the file's style. In this case your code would look like:

  if (typeof(this.tryToClose) == "function" && !this.tryToClose())
    return;

sr=jag with that.

Comment 5

[Tim]

Attachment: fix nits

Old habits die hard.  Nits addressed.

Carrying over sr=jag.

Comment 6

[Tim]

Attachment: Slightly different approach

Spoke with Neil some, and here is a slightly different approach. It's mostly
the same thing.

Not carrying anything over.

Comment 7

[jag (Peter Annema)]

Comment on attachment 126538 [details] [diff] [review]
Slightly different approach

sr=jag

Comment 8

[Tim]

Fix checked in.

Comment 9

[Jason Bassford]

.