210683 - servername.sbd is created if ImapMail directory doesn't exist

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Henrik Gemal]

if you delete the ImapMail directory, like I normally do when Mozilla screws up
my IMAP mails, Mozilla creates a subdirectory called "[your imap
servername].sbd" instead of just "[your imap servername]"

basiclly it's a problem in CreateDirectoryForFolder and AddDirectorySeparator

the problem with the "[your imap servername].sbd" is that the next time mozilla
is launched your mail settings are remembered. because you end up with two
directories.

20030623

Comment 1

[Henrik Gemal]

if you add:

nsFileSpec tempPath(pathResult.GetNativePathCString(), PR_TRUE);

just before the CreateDirectory() it works!
http://lxr.mozilla.org/mozilla/source/mailnews/imap/src/nsImapUtils.cpp#142

attaching diff/patch

Comment 2

[Henrik Gemal]

Attachment: patch to fix imapservername.sbd creation

Comment 3

[Henrik Gemal]

Comment on attachment 126490 [details] [diff] [review]
patch to fix imapservername.sbd creation

David: could you review this?

Comment 4

[David :Bienvenu]

can you add a comment to the code as to why that works? Presumably, it creates
the parent directory w/o the .sbd as a side-effect...do we even need the
CreateDirectory call after it now?

Comment 5

[Henrik Gemal]

Attachment: patch with note

Comment 6

[Henrik Gemal]

Comment on attachment 126493 [details] [diff] [review]
patch with note

the:
pathResult.CreateDirectory();
is still needed.

Comment 7

[David :Bienvenu]

I'll need to figure out *why* this works before I can sr it. I'll try to get to
it as soon as I can.

Comment 8

[Henrik Gemal]

I've got another bug where using the GetNativePathCString also helps. It's bug
209641

Comment 9

[Henrik Gemal]

David: any update of this bug and the patch?

Comment 10

[David :Bienvenu]

Does this happen if you just delete the server-specific sub-directory instead of
the ImapMail directory? It didn't happen to me...I can try deleting the ImapMail
directory...I' need to see what goes wrong before I can see the fix working.

Comment 11

[David :Bienvenu]

I tried deleting ImapMail in another profile, and I didn't see this bug happen -
actually, looking more closely, it happened for one account but not another. So
I need to figure out why.

Comment 12

[Henrik Gemal]

normally I delete the entire imapmail directory.
I think I testes this with check_all_folders pref woth on and off

Comment 13

[Henrik Gemal]

David: you're really buzy working those IMAP bugs. Any update with this one?

Comment 14

[David :Bienvenu]

I have been busy - I haven't had a chance to see why it happens for one account
and not the others.

Comment 15

[Henrik Gemal]

David: to reproduce this bug:
1) create a clean profile with a imap account and log into the account.
2) quit thundeerbird or mozilla mail
3) delete the following files and directories:
panacea.dat
XUL.mfl
ImapMail
3) start mozilla mail or thunderbird you see the servername.sbd directory under
ImapMail:

via debug I see:
gemal: dbName: C:\DOCUMENTS AND SETTINGS\HENRIK GEMAL\APPLICATION DATA\Thunderbi
rd\Profiles\mail\rge83luq.slt\ImapMail\imap.gemal.dk.sbd\INBOX.msf
gemal: CreateNewFile: C:\DOCUMENTS AND SETTINGS\HENRIK GEMAL\APPLICATION DATA\Th
underbird\Profiles\mail\rge83luq.slt\ImapMail\imap.gemal.dk.sbd\INBOX.msf

Comment 16

[David :Bienvenu]

fix checked in, r/sr=me. Thx, Henrik, sorry it took me so long.

Comment 17

[Henrik Gemal]

isn't this already checked in?

http://lxr.mozilla.org/mozilla/source/mailnews/imap/src/nsImapUtils.cpp#142

Comment 18

[David :Bienvenu]

yes, it's checked in, and marked fixed.