210721 - Remove MOZ_PSM from directory/xpcom

Status: NEW

(Directory :: LDAP XPCOM SDK, enhancement)

Description

[timeless]

Comment 1

[timeless]

Attachment: changes

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

I don't understand what you're trying to do here and why.  Please explain.

Comment 3

[Mike Kaply [:mkaply]]

timeless, please explain this patch (reply to Dan)

Comment 4

[timeless]

i'd like to be able to build directory/xpcom without building psm, and when I
later drop in psm have it pick up the psm. this is how components should work.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 126519 [details] [diff] [review]
changes

>Index: Makefile.in
>===================================================================
>RCS file: /cvsroot/mozilla/directory/xpcom/base/src/Makefile.in,v
>retrieving revision 1.23
>diff -u -r1.23 Makefile.in
>--- Makefile.in
>+++ Makefile.in
>@@ -61,23 +61,20 @@
> 		nsLDAPBERValue.cpp \
> 		$(NULL)
> 
>+DEFINES         += -UMOZ_PSM
>+

Why the above change useful or necessary?

r+sr=dmose, with the provision that you either get rid of that change, or
convince me why it's a good idea.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

timeless:
RCS file: /cvsroot/mozilla/directory/xpcom/base/src/nsLDAPSecurityGlue.cpp,v
 // Only build this code if PSM is being built also

this seems to be wrong now that the define is removed.