21085 - If file exists in target location, filemove returns -201 error (not specific enough).

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[David Epstein]

build 1999120608-M12. reproduced on Win98. also see 20773
Make sure that smrtupdt.txt is not located in /TEMP
1. Go to XPInstall test page: http://jimbob/trigger2.html.
2. From the dropdown menu, select a_fileop_filemove.
3. Press Trigger case. OK.
4. Check target directory (/TEMP). smrtupdt.txt should be there.
at this point, logfile looks like this:
     Acceptance: a_fileop_filemove
     -----------------------------

     ** Path to fileSource = C:\Program Files\Netscape\Seamonkey\smrtupdt.txt
     ** Path to fileTarget = C:\TEMP\
     ** fileMove returns = 0
     Item [1/2]	Installing: C:\Program Files\Netscape\Seamonkey\smrtupdt.txt
     Item [2/2]	Move File: C:\Program Files\Netscape\Seamonkey\smrtupdt.txt to
C:\TEMP\

     Install completed successfully
     Finished Installation  12/07/1999 10:50:44
5. Run filemove script a 2nd time.
6. Check logfile.
Result 2: (logfile contents):
     Acceptance: a_fileop_filemove
     -----------------------------

     ** Path to fileSource = C:\Program Files\Netscape\Seamonkey\smrtupdt.txt
     ** Path to fileTarget = C:\TEMP\
     ** fileMove returns = 0
     Item [1/2]	Installing: C:\Program Files\Netscape\Seamonkey\smrtupdt.txt

     Install **FAILED** with error -201

     Install **FAILED** with error -201
     Finished Installation  12/07/1999 10:51:06

Expected: Filemove install is successful w/o errors.

Here is the filemove script:

////////////////////////////////////////////////////////////////////////////////
////////
// a_fileop_filemove.js
//
// Acceptance test
// 	• Checks if a known file can be moved to known directory
//
// ~ XPInstall QA
//   October 12, 1999
////////////////////////////////////////////////////////////////////////////////
//////////

jarSrc = "smrtupdt.txt";

startInstall("Acceptance: a_fileop_filemove", "acceptance", "1.1.1.1", 0);
f = getFolder("Program");
g = getFolder("Temporary");
addFile("fileop_filemove", "2.2.2.2", jarSrc, f, jarSrc, true);
fileSource = f + jarSrc;
fileTarget = g;
err1 = fileMove(fileSource, fileTarget);
logComment("Path to fileSource = " + fileSource);
logComment("Path to fileTarget = " + fileTarget);
logComment("fileMove returns = " + err1);

if (0 == getLastError())
	finalizeInstall();
else
	abortInstall();

Comment 1

[Jimmy Lee]

Reassigning QA Contact to David.

Comment 2

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine

Comment 3

[Phil Peterson]

*** Bug 21984 has been marked as a duplicate of this bug. ***

Comment 4

[Daniel Veditz [:dveditz]]

Maybe I'm misunderstanding the bug, but you cannot "move" a file on top of a
file that already exists. Try "mv" in unix, or "ren" in DOS.

Comment 5

[David Epstein]

reopened bug. Summary changed from the problem being that the script failed to
returning a more descriptive error. currently, it returns -201 = unexpected
error. A couple of ideas for better error #s are -230 = already exists, -226 =
filename already used.

Comment 6

[leger]

Clearing INVALID resolution due to reopen of this bug.

Comment 7

[Cathleen]

reassign to ssu (please also check if filecopy has this problem, and apply fix
too)

Comment 8

[Sean Su]

fixed.  it will now return error -230 and trigger the abortInstall() function
instead of dying a horrible death in finalizeInstall().

I've also fixed the same problem with fileCopy().

Comment 9

[David Epstein]

now returns -230 error and script aborts.