211031 - Mail with only BCCs cannot be sent "Later" (also saves corrupt draft)

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Richi Jennings]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624

If I compose a message with only BCC reipients, and keep it in "Unsent Messages"
(i.e. File|SendLater), the message will not send, because the header gets
corrupted with a bogus "undisclosed-recipients". The same is true if I save it
as draft.

Reproducible: Always

Steps to Reproduce:
1. Compose mail with only BCC recipient(s)
2. File|SendLater
3. File|SendUnsentMessages

Actual Results:  
SMTP server complains "4.1.1 user unknown" (presumably due to corrupted header
causing bogus RCPT TO). If you then look in Unsent Messages, you can see a bogus
TO recipient.

Expected Results:  
Header should not be corrupted by bogus recipients. Send Later function should
work as advertised.

This used to work OK in 1.2 and previous builds.

Related to bug#189263.

Comment 1

[Pascal Chevrel:pascalc]

confirmed with build 2003062307 WinXP

Works ok with Netscape 7.02, regression. Adding regression, nsbeta1 and mail4
keywords.

Comment 2

[Asa Dotzler [:asa]]

mozilla1.4 shipped. unsetting blocking1.4 request.

Comment 3

[Richi Jennings]

Still a problem in released 1.4. Grumble.

Comment 4

[chris hofmann]

sspitzer, any cycles to look at this?

Comment 5

[Scott MacGregor]

I'll take this. 

Comment 6

[Asa Dotzler [:asa]]

scott, do you think you'll be able to get to this in the next day or two for 1.5
beta?

Comment 7

[Scott MacGregor]

Attachment: the fix (don't insert undisclosed line if isDraft is true)

isDraft is set to true if we are sending later, saving as draft or saving as
template. In all three cases, we will re-enter this routine whe we are sending
the message for real.

Comment 8

[David :Bienvenu]

Comment on attachment 129468 [details] [diff] [review]
the fix (don't insert undisclosed line if isDraft is true)

sr=bienvenu

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 129468 [details] [diff] [review]
the fix (don't insert undisclosed line if isDraft is true)

a=asa (on behalf of drivers) for checkin to 1.5beta.

Comment 10

[Scott MacGregor]

fixed.