211177 - Right double clicking a DM item launches it

Status: VERIFIED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Frank Burleigh]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030630
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030630

Assume a right-handed mouse.  Using the *right* mouse button, double click an
item in DM's list of downloaded files.  The DM will offer to launch that item. 
I do not believe double clicks using the right mouse is a normal user idiom.

Reproducible: Always

Steps to Reproduce:
1. download a file using DM.
2. in DM, double click the file with the right mouse button
3. DM will offer to launch the file, and a stray context menu will be on-screen.



Expected Results:  
Right mouse double click should probably do nothing--at most leaving a context
menu I'd think.

Comment 1

[Jesse Ruderman]

Might be bug 217560.

Comment 2

[Ian Neal]

*** Bug 211927 has been marked as a duplicate of this bug. ***

Comment 3

[Ian Neal]

This will probably be fixed by the 2nd patch on bug 244692

Comment 4

[Steffen Wilberg]

Bug 244692 is for Firefox only. The patch will not affect Seamonkey. Removing
dependency.

Comment 5

[Ian Neal]

Attachment: Patch v0.1

This is the non-firefox part of Ben Basson's ([e-mail]) patch from
bug 244692.

Comment 6

[[e-mail]]

Comment on attachment 153909 [details] [diff] [review]
Patch v0.1

>+  if (aEvent.button !=0)
I had the comment all ready to point out the missing space between != and 0 and
then clicked on Undo Edit As Comment and forgot all about it until after I
clicked Submit :-[
Could whomever's fixing the whitespace also kill the spaces on the preceding
blank line, thanks.

Comment 7

[Ian Neal]

Attachment: Tweaked version of patch v0.1 including whitespace tidyup

Adds missing space to != and does whitespace tidy ups as suggested by Neil

Comment 8

[Ian Neal]

Comment on attachment 153937 [details] [diff] [review]
Tweaked version of patch v0.1 including whitespace tidyup

Carrying forward r= and requesting sr

Comment 9

[jag (Peter Annema)]

Comment on attachment 153937 [details] [diff] [review]
Tweaked version of patch v0.1 including whitespace tidyup

I'd say put a blank line after the early return for readability before you
check in. sr=jag either way though

Comment 10

[Ian Neal]

Attachment: Patch v0.1b for checkin

With extra blank line after early return as per jag's comment.

Comment 11

[Ian Neal]

Comment on attachment 153953 [details] [diff] [review]
Patch v0.1b for checkin

Carrying forward r/sr=

Comment 12

[[e-mail]]

Fix checked in.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using trunk build 2006-01-04-09 of SeaMonkey on Windows XP.