211188 - Test for any #! lines that are not /usr/bin/perl

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[Zach Lipton [:zach]]

Spinoff from bug 211127:

We need to add something to goodperl.t to look for shebang lines that point to
/usr/bonsaitools/bin/perl or another other than /usr/bin/perl. 

At the same time, we should be careful since admins may modify the shebang line
of every cgi and we don't want massive test failure.

Comment 1

[Dave Miller [:justdave]]

if they modify the rest of the files, they can modify the test, too.

We can point this out in the docs where we talk about modifying the #! line,
too, and point out that it's a good test to run to make sure they got all of
them, too :)

Comment 2

[Burak Ozyurt]

In distribution file bugzilla-2.16.5.tar.gz all she-bang lines pointed to
/usr/bonsaitools/bin/perl , but most Linux distributions have Perl in
/usr/bin/perl. Before a distribution those can be easily changed to more common
Perl location.

Comment 3

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 4

[Vlad Dascalu]

Comment on attachment 157139 [details] [diff] [review]
Patch

There is redundancy regarding the location of the perl script.

Dave said in item1 something about admins changing this location in the testing
suite as well, so we should make this easy for them. I'd prefer to have a
variable or something like that containing '/usr/bin/perl', and use that
instead of hard-coding '/usr/bin/perl' each time we need it. It removes
redundancy as well.

Or redesign the code so that '/usr/bin/perl' appears only once in the 002 test
:)

Comment 5

[Marc Schumann [:Wurblzap]]

Attachment: Patch v1.2

(In reply to comment #4)
> Or redesign the code so that '/usr/bin/perl' appears only once in the 002
test
> :)

Ok, did that.

Comment 6

[Christian Reis]

Ideally a new patch should be attached for committing with the updates. Thanks :)

Comment 7

[Marc Schumann [:Wurblzap]]

kiko: what exactly are you missing? Attachment 157312 [details] [diff] is up to date, right?

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Waiting for Christian to respond before approving.

Comment 9

[Marc Schumann [:Wurblzap]]

(In reply to comment #6)
> Ideally a new patch should be attached for committing with the updates. Thanks

kiko: I hope you don't mind me ccing you -- was this meant for some other bug,
perhaps?

Comment 10

[Christian Reis]

Sorry, it was meant for another bug, ignore me :)

Comment 11

[Vlad Dascalu]

Checking in t/002goodperl.t;
/cvsroot/mozilla/webtools/bugzilla/t/002goodperl.t,v  <--  002goodperl.t
new revision: 1.15; previous revision: 1.14
done
Checking in t/002goodperl.t;
/cvsroot/mozilla/webtools/bugzilla/t/002goodperl.t,v  <--  002goodperl.t
new revision: 1.13.2.2; previous revision: 1.13.2.1
done

Comment 12

[Shane H. W. Travis]

Bug 278336 has been added to incorporate documentation changes for this 
enhancement.