211371 - undo unneeded nsChangeHint_AttrChange optimization?

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the optimization in bug 68103 is now no longer needed thanks to the
patch for bug 163556.  I need to investigate this a little more, though.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This also requires understanding what the fix to bug 157210 was attempting to do.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Regarding bug 157210 -- NS_STYLE_HINT_CONTENT is the default -- unmapped --
NS_STYLE_HINT_ATTRCHANGE says not to attempt to reresolve style.  I think it's
just a bug and the whole thing can be removed.)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Indeed, since it looks like that will break style rules using the "value" attr
selector on some input types....  We just want the hint to be "content" for that
attr, period.

Perhaps the CONTENT/ATTRCHANGE hints need to be better documented; you
description in this bug is a lot clearer than what the header says.  ;)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Here's a first attempt at a patch.  There's been a lot of "right hand doesn't
know what the left hand is doing" in this part of the code, and this is an
attempt to clean some of it up.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

as i recall it, the change in bug 157210 was only made to make the
value-attribute not be considered a mapped attribute, therefor making it not
shared across elements. It did not intend to actually affect layout in any way.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Subsumed by bug 211308.