211570 - Implement close button and spinning wheel inside tabs like in Safari

Status: RESOLVED FIXED

(Camino Graveyard :: Tabbed Browsing, enhancement)

Description

[Jérome Foucher]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5a) Gecko/20030627 Camino/0.7+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5a) Gecko/20030627 Camino/0.7+

Right now the only way to close a specific tab is to control-clik on the tab
(which will not be hilited by the way) and selected "Close Tab" from the
contextual menu.

It would be interessant to implement a close button (cross icon) inside the tab
to close the tab directly, just like in Apple's Safari.

A spinning wheel showing that a tab is currently loading a page would be cool
too. I know it won't work in 10.1.x but at least in 10.2 that would be a nice
addition (I've coded that too).

Reproducible: Always

Steps to Reproduce:
1.
2.
3.




I have already coded that, but don't know how to submit the changes I've made to
Camino, so feel free to contact me at [e-mail] for further details

Comment 1

[[e-mail]]

I like the spinning thingy. But I don't think the close box is a good idea.
Often times when I want to click at a tab in Safari to bring that tab to front,
I will accidentally click at that box and close that tab.

Comment 2

[Mike Pinkerton (not reading bugmail)]

as a comment, people i've talked to about the close button say that while they
do have problems doing this a few times, it's a learned behavior and they learn
not to do that. maybe that's good enough? seems rather "ow, quit it" to me though.

we're prolly gonna have to do our own look for tabs since they look pretty bad
under panther. maybe we can look at this.

Comment 3

[Stefan [:stefanh]]

I would really appreciate a close button (like Thunderbird and Moz). I think
it's a great feature. 

Comment 4

[Stefan [:stefanh]]

Sorry for the spam...

Of course Firebird and Moz doesn't have any close buttons inside the tabs (for a
short moment I felt that they had). But instead of a close button inside the
tabs wouldn't it be cool if you had a small button on the same line as the tabs?

Comment 5

[Jasper]

The way Mozilla let's users close a tab isn't that different from what Camino is
doing now. In both browsers the user is forced to move his/her mouse a great
distance to close a tab. Especially when having a large monitor and multiple
tabs (closing the left most tab forces the user to go to the right side of the
screen)

The beauty of the consept used in Safari is that every tab has a close buttun
which results in less mouse movement for the user. And on the other side  I
think it's  also much more intuitive to put it on the tab it self, that's what
done with windows to. 

We wouldn't like it if we had to go to a toolbar buttun if we had to close our
windows now would we? The consequence of tabbed browsing is that some people
will use it more and more since it is a time and space reducing feauture. And
refining this feature to make sure even less time and space is used sound god to me.

Besides, why is that site icon on the tab it's already shown in the url bar?

Comment 6

[Sergey Kirienko]

I think it should be Hardware/OS "All" bug.

Firebird should have "Close Tab" x-button at the right side of every tab, as
Safari and Opera browsers and Eclipse IDE do. That is a right behaviour.

Or, at least, it would be an option (use one close button or many).

Comment 7

[Greg K.]

Jérome, please create a CVS diff file of your patch and attach it to this bug.

Comment 8

[Jérome Foucher]

Attachment: Diff to implement a close button and a progress wheel in tabs

Comment 9

[Jérome Foucher]

Attachment: cross icon to be used as the close button in tabs

Comment 10

[Jérome Foucher]

Attachment: cross icon to be used as the close button in tabs (when button pressed)

Comment 11

[Warren TenBrook]

FWIW, nobody has explicitly mentioned the existing "Close Tab" custom toolbar
button.  The toolbar button is a larger target and can be placed in a consistent
position for minimal mousing around.  I find this preferable to Safari or
Omniweb 5's microscopic tab close widgets, assuming one does not need to close
tabs in the background often.

Comment 12

[Mike Pinkerton (not reading bugmail)]

we wouldn't remove the toolbar button when we land this. as you say, the
consistent position is a strong argument. i think the per-tab close is worth
having in the build and experimenting.

Comment 13

[Mike Pinkerton (not reading bugmail)]

i cleaned this patch up a bunch, changed names, and only show the spinner for
10.2 and up (since it doesn't exist as a widget in 10.1). for 10.1 we'll only
show the close button. I think that's a reasonable compromise instead of
inventing our own.

THe images need some work, hopefully jasper can provide better ones once this lands.

thanks for the code!!

Comment 14

[Jérome Foucher]

I tried to attach the original images (they came from Safari) that were in TIFF format.

However, bugzilla did not let me do that. So I had to convert them quickly in PNG and I suspose the 
convertion was not perfect.

Thanks for cleaning up the code. I know it was a bit rough. I had to implement that quickly so I just did 
something that worked....

Comment 15

[Mike Pinkerton (not reading bugmail)]

landed, turning off spinner support in < 10.2