211576 - Make use of 'forced' param in nsIHelperAppLauncherDialog (Content-Disposition "attachment")

Status: RESOLVED WONTFIX

(Camino Graveyard :: Downloading, enhancement)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

I hope I picked the right component-

bug 193698 added a third argument to nsIHelperAppLauncherDialog::Show, called
aForced.

It is true if the server sent a Content-Disposition of "attachment", which means
that Mozilla (Gecko) will always show the dialog, even if the type could be
handled internally or if the user asked to remember his choice.

Maybe Camino has a use for this parameter. (I changed the function definition to
add this parameter, but it is unused at the moment)

(The affected file is mozilla/camino/src/embedding/CHBrowserService.mm)

Comment 1

[Josh Aas]

-> pinkerton

Comment 2

[Jasper]

Mike what the hell is this bug about?

Comment 3

[Samuel Sidler (old account; do not CC)]

Like comment 2, I wonder what this bug means. :)

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I can't find the bug now where Wevah and I had this conversation, but
bugzilla.neooffice.org serves up all its attachments with "Content-Disposition:
attachment" HTTP headers, which by spec "forces" Gecko to download the items,
even if they could be displayed inline (i.e., foo.txt, bar.jpg, baz.pdf)

Biesi was kind enough to inform us that there's now an option available that
Camino could conceivably implement to override the "forced" download of files
sent with that HTTP header and instead allow those items to display inline if
they're a type that can be displayed inline.

Or something approximating that.

I'd like this option for dealing with b.n.o, but it seems pretty geeky, and I
don't think we use that helper app dialogue at all--if we can handle the file
inline/inline w/plugin, we do; else, the file is downloaded.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

no, this bug is different. There are two ways the helper app dialog can be
shown: Either for an unsupported mime type, or for
content-disposition:attachment. Camino may want to show a different message for
these cases.

If it does not want to differ between them, this bug can be marked WONTFIX.

comment 4 is different, that feature does not exist yet.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mike, Simon: do we ever show the helper app dialogues, and/or do the Gecko prefs to show them function in Camino?  If the answer to both is no, this is WONTFIX, right (or is it WONTFIX regardless)?

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Smokey Ardisson (back-ish; no bugmail - do not email) from comment #6)
> Mike, Simon: do we ever show the helper app dialogues, and/or do the Gecko
> prefs to show them function in Camino?  If the answer to both is no, this is
> WONTFIX, right (or is it WONTFIX regardless)?

So, we never show an intermediate dialogue here (we either download directly, or, if someone flips the hidden pref, directly show the filepicker).  We never care why we hit that codepath, and almost certainly never will (but thanks to biesi for filing the bug anyway and explaining it ;-) ).