211577 - [ActiveX / MFCEmbed] api change in nsIHelperAppLauncherDialog

Status: RESOLVED INVALID

(Core Graveyard :: Embedding: ActiveX Wrapper, enhancement)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

bug 193698 added a third argument to nsIHelperAppLauncherDialog::Show, called
aForced.

It is true if the server sent a Content-Disposition of "attachment", which means
that Mozilla (Gecko) will always show the dialog, even if the type could be
handled internally or if the user asked to remember his choice.

Maybe the activex wrapper has a use for this parameter. (I changed the function
definition to add this parameter, but it is unused at the moment)

(The affected file is embedding/browser/activex/src/control/HelperAppDlg.cpp)

Comment 1

[louis bennett]

*** This bug has been marked as a duplicate of 211578 ***

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

no this is not a duplicate. the files are entirely separate.

Comment 3

[Adam Lock]

I'm not sure I understand what this parameter does. By the time that
nsIHelperAppLauncherDialog::Show is called, it doesn't really matter what the
control / mfcembed thinks - it has been told to show the helper dialog and that
is what it must do. So what should I do if aForced says PR_TRUE?

Is the aForced param meant to change the behaviour of the dialog in some way &
if so, how?

I will dupe 211578 against this, because the issue is the same for both.

Comment 4

[Adam Lock]

*** Bug 211578 has been marked as a duplicate of this bug. ***

Comment 5

[Boris Zbarsky [:bzbarsky]]

> it has been told to show the helper dialog and that is what it must do. So what
> should I do if aForced says PR_TRUE?

Well, the xpfe dialog shows different text if aForced is true -- if aForced is
true that means the site asked us to show the dialog, not necessarily that we
don't know how to handle the type (in particular, the dialog could come up for
something like text/html when aForced is true).

Comment 6

[Ed Morley [:emorley]]

The ActiveX embedding API was removed in bug 662023 and friends, making this INVALID.

[Filter bugspam on activexinvalid]