211758 - default parameter handling broken during upgrade

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P1)

Description

[Brad Roberts]

Default parameter handling is broken, I believe.  During the upgrade from 2.16.3
to 2.17.cvs-tip, checksetup.pl was choaking due to a not found parameter
loginmethod.  The problem was fixed with the attached patch.

Comment 1

[Brad Roberts]

Attachment: Fix for Burzilla/Config.pm default parameter handling

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 127066 [details] [diff] [review]
Fix for Burzilla/Config.pm default parameter handling

hmmmm....   something doesn't smell right here...  maybe I'm just clueless
tonight, but I better have bbaetz take a look.

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 127066 [details] [diff] [review]
Fix for Burzilla/Config.pm default parameter handling

ok, this isn't the solution.  Will explain in a moment.

Comment 4

[Dave Miller [:justdave]]

The real problem here is we have a |use Bugzilla::Series;| in checksetup.pl.

Which has a |use Bugzilla|.  which does |use Bugzilla::Auth|.  Which tries to
load params at compile time of checksetup.pl.

So this was introduced with the new charting patch.

Comment 5

[Brad Roberts]

Attachment: alternate fix to not use but rather require Bugzilla::Series

Comment 6

[Dave Miller [:justdave]]

Comment on attachment 127067 [details] [diff] [review]
alternate fix to not use but rather require Bugzilla::Series

This is your code, Gerv.  Still do what you want it to like this?

Comment 7

[Dave Miller [:justdave]]

-> patch author

Comment 8

[Bradley Baetz (:bbaetz)]

As long as we're not importing anything...

Mayeb the param updates should be done in a BEGIN, like th eversion checking now
is (or now is after one of my patches, rather)

Comment 9

[Dave Miller [:justdave]]

Comment on attachment 127067 [details] [diff] [review]
alternate fix to not use but rather require Bugzilla::Series

OK, I gave up waiting on Gerv.	It works.  Looking in Bugzilla::Series, it
doesn't look like it attempts to export anything, so we don't need an import.

Comment 10

[Dave Miller [:justdave]]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.235; previous revision: 1.234
done

Comment 11

[Gervase Markham [:gerv]]

Sorry, guys - just too much on my plate at the moment.

Gerv