default parameter handling broken during upgrade

RESOLVED FIXED in Bugzilla 2.18

Status

()

defect
P1
major
RESOLVED FIXED
16 years ago
7 years ago

People

(Reporter: braddr, Assigned: braddr)

Tracking

({regression})

2.17.4
Bugzilla 2.18
x86
Linux
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

Default parameter handling is broken, I believe.  During the upgrade from 2.16.3
to 2.17.cvs-tip, checksetup.pl was choaking due to a not found parameter
loginmethod.  The problem was fixed with the attached patch.
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.18
Comment on attachment 127066 [details] [diff] [review]
Fix for Burzilla/Config.pm default parameter handling

hmmmm....   something doesn't smell right here...  maybe I'm just clueless
tonight, but I better have bbaetz take a look.
Attachment #127066 - Flags: review?(bbaetz)
Comment on attachment 127066 [details] [diff] [review]
Fix for Burzilla/Config.pm default parameter handling

ok, this isn't the solution.  Will explain in a moment.
Attachment #127066 - Flags: review?(bbaetz) → review-
The real problem here is we have a |use Bugzilla::Series;| in checksetup.pl.

Which has a |use Bugzilla|.  which does |use Bugzilla::Auth|.  Which tries to
load params at compile time of checksetup.pl.

So this was introduced with the new charting patch.
Keywords: regression
Attachment #127066 - Attachment is obsolete: true
Comment on attachment 127067 [details] [diff] [review]
alternate fix to not use but rather require Bugzilla::Series

This is your code, Gerv.  Still do what you want it to like this?
Attachment #127067 - Flags: review?(gerv)
-> patch author
Assignee: zach → braddr
As long as we're not importing anything...

Mayeb the param updates should be done in a BEGIN, like th eversion checking now
is (or now is after one of my patches, rather)
Comment on attachment 127067 [details] [diff] [review]
alternate fix to not use but rather require Bugzilla::Series

OK, I gave up waiting on Gerv.	It works.  Looking in Bugzilla::Series, it
doesn't look like it attempts to export anything, so we don't need an import.
Attachment #127067 - Flags: review?(gerv) → review+
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.235; previous revision: 1.234
done
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: approval+
Resolution: --- → FIXED
Sorry, guys - just too much on my plate at the moment.

Gerv
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.