21220 - Confirm dialogs go off screen.

Status: VERIFIED WORKSFORME

(SeaMonkey :: UI Design, defect, P3)

Description

[scalkins]

Saw this on Linux and Win builds, not on the Mac.
Build 1999-12-08-08 M12
Two test cases follow:

Test case 1:
1)Launch Seamonkey.
2)When Mozilla comes up, resize it so it's about 5 inches wide, then move it to
the right so it's right border lines up with the right side of your screen.
3)Type the following in the Mozilla URL field, then hit enter:
javascript:/alert("foo foo")

Actual Results: A dialog box appears with part of the dialog off screen.

Test Case 2:

1)Launch Seamonkey and Login to IM via Tasks-->Instant Messenger
2)When the Standalone comes up, Move it to the extreme right of the screen, such
that the standalone's right border lines up with your screen's right border.
3)In List setup tab, click once on a group to highlight it, then click on the
Delete icon to delete it.

Expected results: Delete confirmation dialog comes up centered on screen so you
can either click the OK or Cancel buttons.

Actual Results: Only about 1/4 of the delete confirmation dialog shows, the rest
of it goes off screen to the right. You must drag it to the left to be able to
click on the OK or Cancel buttons.

Comment 1

[davidm]

Accept. Dialogs should be constrainted to fit on the same screen as the parent.
Is this a dogfood bug ( ie can the window get in a state where it can not be
dismissed?)

Comment 2

[Alex Musil]

I don't think this needs to be dogfood.

Comment 3

[davidm]

Fix is to move the fittoscreen code from navigator.js to dialog.js ( or someother
global place) and add a call after moving the dialog to the alert positiion. This
will not work however until screenX returns something other than 0. Added
dependency. Accepted.

Comment 4

[don]

M15.

Comment 5

[don]

Move to M16 for now ...

Comment 6

[Paul MacQuiddy]

changing qa contact on selected bugs from paulmac to [e-mail]

Comment 7

[verah (gone)]

Reassigning for Don

Comment 8

[leger]

Need this tested with latest build please.

Comment 9

[John Morrison]

Scenario 1: javascript:alert

  I can't _strictly_ reproduce this (entering a javascript: URL in the urlbar 
  is currently broken -- bug #38537). 
  
  However, using <A HREF="javascript:alert('foo foo')">, the alert is placed
  in the horizontal center of the browser window (not offscreen or biased to   
  offscreen). Not a problem.


Scenario 2: AIM delete group dialog

 win95 -- the dialog comes up aligned with the left edge of the parent
 window (the IM window) (see attachment). However, since the text in the
 dialog does not wrap, the dialog window is wide enough that part of the
 text is displayed offscreen. I assume that with more text, the OK button
 could appear offscreen. 

 mac and linux -- dialog is in the center of the desktop/screen (not a problem)

(using 20000510nn latest mac/linux/win95)

Comment 10

[John Morrison]

Attachment: screenshot; dialog partially offscreen, if dialog text does not wrap

Comment 11

[leger]

Putting on [nsbeta2+][6/01] radar.  This work must be done by 06/01 or we may 
pull this for PR2.

Comment 12

[leger]

Changing from [06/01] to [06/15]

Comment 13

[don]

Move to M19 target milestone.

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

worksforme. This window is centered on screen, no matter what I do to it in js 
(it doesnt even come up off screen..)

Comment 15

[John Morrison]

verified worksforme (mac/linux/win32 20000707nn builds). alert|confirm comes
up at screen center (approx.) in all cases. 

[That, though, is possibly a bug in its own right, but I will speak with danm 
about that (he is dealing with various windowing/modality/parenting bugs right 
now)].