212245 - don't build ftp and gopher directory listing support if protocols are disabled

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Darin Fisher]

if necko has been configured with FTP and/or Gopher disabled, then don't build
the corresponding directory listing converters.

Comment 1

[Darin Fisher]

Attachment: v1 patch

simple patch

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 127409 [details] [diff] [review]
v1 patch

we will probably want to get rid of nsIndexToHTML, nsDir* and other directory
listing stuff based on some new flag.  the assumption is that won't want
directory file listings.  

do you want a new bug?

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 127409 [details] [diff] [review]
v1 patch

simple fix.  doesn't change the default mozilla build

Comment 4

[Darin Fisher]

>we will probably want to get rid of nsIndexToHTML, nsDir* and other directory
>listing stuff based on some new flag.  the assumption is that won't want
>directory file listings.  
>
>do you want a new bug?

yeah, i'll take care of that separately.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 127409 [details] [diff] [review]
v1 patch

We're probably going to branch tomorrow, and I don't see why we particularly
want this in 1.5alpha (since they're not disabled in our releases), so could
you hold off on this?

Or is there something I'm missing?

Comment 6

[benc]

what about file: ?

Comment 7

[Darin Fisher]

benc: please see comment #4.

Comment 8

[Darin Fisher]

fixed-on-trunk

this should shave some bytes off the size of tbird builds ;)

Comment 9

[Scott MacGregor]

sweet. thanks darin!