212504 - namespaceID argument to nsCSSLoader::CreateSheet() should be PRInt32

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

/usr/local/src/mozilla/trunk/mozilla/content/html/style/src/nsCSSLoader.cpp: In 
   member function `nsresult CSSLoaderImpl::InternalLoadAgentSheet(nsIURI*, 
   nsICSSStyleSheet**, nsICSSLoaderObserver*)':
/usr/local/src/mozilla/trunk/mozilla/content/html/style/src/nsCSSLoader.cpp:1838:
warning: passing
   negative value `-1' for argument 3 of `nsresult 
   CSSLoaderImpl::CreateSheet(nsIURI*, nsIContent*, unsigned int, int, 
   StyleSheetState&, nsICSSStyleSheet**)'

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

Actually, I've been considering removing this argument altogether.  We never use
it (just like we never use the default namespace stuff in the parser and
CSSStyleSheet).  Do we have plans to use any of it?

Comment 3

[Hixie (not reading bugmail)]

(dunno about this particular argument, but AIUI, the default namespace stuff was 
a misguided "feature" from the late 90s that never really worked and has no good 
reason to exist.)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Well, all this argument does is set the default namespace on sheets loaded via
that cssloader....

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Removes the arguments completely

Per discussion with bz

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Better fix

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 127789 [details] [diff] [review]
Better fix

r=bzbarsky if you take out that stray printf.

dbaron, could you sr?  I don't think there are any issues with this, but you're
more familiar with the CSSStyleSheetImpl code....

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 127789 [details] [diff] [review]
Better fix

sr=dbaron if you fix nsMathMLFrame::MapAttributesIntoCSS (which I think you
need to do)

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Oh, good catch.  Fixed both your comments and checked in 07/17/2003 18:26.