212518 - Forms are submitted twice; second time empty

Status: VERIFIED DUPLICATE of bug 209375

(Firefox :: General, defect)

Description

[Jonas Linde]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030710 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030710 Mozilla Firebird/0.6

When loading a form containing an input of type "image" the page is immediately
requested again via an empty GET. The only real world example where I know this
bug is a problem is at http://www.sj.se/page/1,4456,,00.html but it might be a
tumbling block at any e-commerce site; depending on how they treat additional
empty form submissions.

Reproducible: Always

Steps to Reproduce:
1.go to http://www.init.se/~jonas/bug209375.asp
2.reload the form at least twice by clicking the "Submit POST request" image


Actual Results:  
both the GET counter and the POST counter are incremented

Expected Results:  
the GET counter should only increment when you submit a GET request

This is a duplicate of both bug 209375 and bug 209764 but those are for
different products (Browser and Camino respectively); I asked around to get an
opinion on whether a bug was needed for the Firebird product too but got no
responses; so I decided to file away.

Comment 1

[Jonas Linde]

Attachment: a patch

This patch resolves the problem; it removes a call to ImageURIChanged from
AfterSetAttr.

The reasoning goes like this: On May 25 the ImageURIChanged function was
changed to fix bug 204386. Before this date the call from AfterSetAttr always
immediately returned NS_OK (due to a compatiblity check) and if it wasn't
supposed to actually do anything it might as well be removed. The fact that
ImageURIChanged is also called in the BeforeSetAttr function seems to indicate
that it is superfluous in AfterSetAttr.

Comment 2

[Jonas Linde]

After having been pointed to the Mozilla Firebird bug guide lines it is now
clear to me that I should not have filed this bug in the first place; resolving
as duplicate of the Browser bug.

*** This bug has been marked as a duplicate of 209375 ***

Comment 3

[Mike Connor [:mconnor]]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b)
Gecko/20030817 Mozilla Firebird/0.6.1+