Closed Bug 21265 Opened 25 years ago Closed 25 years ago

need to code review all form element content objects

Categories

(Core :: Layout: Form Controls, defect, P3)

Product:
Core
Component:
Layout: Form Controls
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: buster, Assigned: pollmann)

Details

(Whiteboard: [DONTTEST])

I just fixed bug 10434 (not yet checked in), which highlighted the problem that the legend content object did not implement nsIFormControl, nor did the content sink call SetForm on legend content objects. Someone should code review all form control elements and verify that this is not a problem for any of them.
Status: NEW → ASSIGNED
OS: Windows NT → All
Hardware: PC → All
Target Milestone: M14
I'll shoot for M14.
Whiteboard: [DONTTEST]
Marking [DONTTEST].
Bulk moving old [donttest] code to new donttest keyword. Sorry for the spam!
Keywords: donttest
Happily, everything that implements nsIFormControl also has SetForm called by nsHTMLContentSink, so the following do both: Button FieldSet Input Label Select TextArea The following do neither: IsIndex (frame not implemented) Legend (will add per buster's patch) OptGroup (intentional) Option (intentional) The ISINDEX lack is already reported in bug 3326. I'll add a comment to look at this bug. As everything else is in order, I'm closing this bug out. Thanks!
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
(This fix can not be verified by anyone, so you'll just have to trust me. :) )
marking verified, code level fix.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.