Closed Bug 212684 Opened 21 years ago Closed 20 years ago
Some chars use Times New Roman MT 30 unnecessarily
This one is hard to explain. We do OS/2 unicode very strange where we convert to the native codepage. For common chars, we should try to use the default font instead of always using Unicode.
Special case a few characters (we already special cased euro) /* euro */ /* bull */ /* ldquo */ /* rdquo */ /* mdash */ I do NOT do hellipse (as was suggested) because in DBCS, ellipses are centered, and bad things happened.
Attachment #127757 - Flags: review?(pedemont)
Attachment #127757 - Flags: review?(pedemont) → review+
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Add lsquo rsquo hellop and ndash to our algorithm
Recently, wrong display of DBCS character "MIDLINE HORIZONTAL ELLIPSIS" revives. This is side effect of Jan-8's fix for this bug, I think. OS2-2004010808: ok OS2-2004010908: ng Test URL: http://www.serina.org/~mozilla/warpzilla1.4/ History: http://groups.google.com/groups?selm=beuo3h%24e23%40ripley.netscape.com Mike, could you reopen this bug?
Add myself to Cc:
What is the behavior now? Is it no longer midline? none of those screenshots are of the current build. Thanks
Behavior is completely same as 1.4 milestone build. No midline. I added a snapshot of 1.6 milestone build to end of the test page.
Logically this doesn't make sense, but I will remove the ellipses code. I believe it is a bug in the OS/2 codepage converters which is mapping the unicode ellipses to the wrong ellipses.
OK, I think I was trying to hard on this one. My IS_SPECIAL code should only be used for 1252 stuff. The problem I was trying to solve here was a problem mainly on western pages. By limiting to the 1252 path, I get the effect I wanted, and Japanese pages work as they did before.
Removing everything from the second case is the wrong idea - then some chars don't display at all. I'm just going to except hellip from the non 1252 case. Works well.
Attachment #141061 - Attachment is obsolete: true
Attachment #141073 - Flags: review?(pedemont)
Comment on attachment 141073 [details] [diff] [review] Bestest patch For legibility, I would split IS_SPECIAL into two lines, so it looks like the other defined. Otherwise, r=pedemont
Attachment #141073 - Flags: review?(pedemont) → review+
My new patch hasn't gone in yet.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Fix checked in to trunk and 1.4
Status: REOPENED → RESOLVED
Closed: 21 years ago → 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.