212684 - Some chars use Times New Roman MT 30 unnecessarily

Status: RESOLVED FIXED

(Core Graveyard :: GFX: OS/2, defect)

Description

[Mike Kaply [:mkaply] (Out until 9/29)]

This one is hard to explain.

We do OS/2 unicode very strange where we convert to the native codepage.

For common chars, we should try to use the default font instead of always using
Unicode.

Comment 1

[Mike Kaply [:mkaply] (Out until 9/29)]

Attachment: Fix

Special case a few characters (we already special cased euro)

/* euro */
/* bull */
/* ldquo */
/* rdquo */
/* mdash */

I do NOT do hellipse (as was suggested) because in DBCS, ellipses are centered,
and bad things happened.

Comment 2

[Mike Kaply [:mkaply] (Out until 9/29)]

Fix checked in.

Comment 3

[Mike Kaply [:mkaply] (Out until 9/29)]

Attachment: More fix

Add lsquo rsquo hellop and ndash to our algorithm

Comment 4

[Achain]

Recently, wrong display of DBCS character "MIDLINE HORIZONTAL ELLIPSIS" revives.
This is side effect of Jan-8's fix for this bug, I think.
OS2-2004010808: ok
OS2-2004010908: ng

Test URL: http://www.serina.org/~mozilla/warpzilla1.4/
History: http://groups.google.com/groups?selm=beuo3h%24e23%40ripley.netscape.com

Mike, could you reopen this bug?

Comment 5

[Achain]

Add myself to Cc:

Comment 6

[Mike Kaply [:mkaply] (Out until 9/29)]

What is the behavior now? Is it no longer midline? none of those screenshots are
of the current build.

Thanks

Comment 7

[Achain]

Behavior is completely same as 1.4 milestone build. No midline.
I added a snapshot of 1.6 milestone build to end of the test page.

Comment 8

[Mike Kaply [:mkaply] (Out until 9/29)]

Logically this doesn't make sense, but I will remove the ellipses code.

I believe it is a bug in the OS/2 codepage converters which is mapping the
unicode ellipses to the wrong ellipses.

Comment 9

[Mike Kaply [:mkaply] (Out until 9/29)]

Attachment: Better patch still

OK, I think I was trying to hard on this one.

My IS_SPECIAL code should only be used for 1252 stuff.

The problem I was trying to solve here was a problem mainly on western pages.

By limiting to the 1252 path, I get the effect I wanted, and Japanese pages
work as they did before.

Comment 10

[Mike Kaply [:mkaply] (Out until 9/29)]

Attachment: Bestest patch

Removing everything from the second case is the wrong idea - then some chars
don't display at all.

I'm just going to except hellip from the non 1252 case.

Works well.

Comment 11

[jhp (no longer active)]

Comment on attachment 141073 [details] [diff] [review]
Bestest patch

For legibility, I would split IS_SPECIAL into two lines, so it looks like the
other defined.	Otherwise, r=pedemont

Comment 12

[Mike Kaply [:mkaply] (Out until 9/29)]

My new patch hasn't gone in yet.

Comment 13

[Mike Kaply [:mkaply] (Out until 9/29)]

Fix checked in to trunk and 1.4