When severity or priority are hidden, CSS class names are incomplete in buglist

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Query/Bug List
RESOLVED FIXED
14 years ago
5 years ago

People

(Reporter: Christian Reis, Assigned: Christian Reis)

Tracking

2.17.4
Bugzilla 2.18
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
When the severity or priority columns are hidden, CSS class names are incomplete
in buglist. Patch coming up
(Assignee)

Comment 1

14 years ago
Created attachment 128015 [details] [diff] [review]
kiko_v1: add severity and priority to default query

How does this look?
(Assignee)

Updated

14 years ago
Attachment #128015 - Flags: review?(jake)

Comment 2

14 years ago
*** Bug 176526 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 3

14 years ago
Tobias, can you give the patch a spin?
Status: NEW → ASSIGNED

Updated

14 years ago
OS: Linux → All
Hardware: PC → All
Comment on attachment 128015 [details] [diff] [review]
kiko_v1: add severity and priority to default query

I want to research the impact of this a little...

I think you'll wind up with prority/severity twice if the user actually picked
it from their column list if you do this (and it'll probably cause an SQL error
under those circumstances).  I think there's more code in Search.pm you'll have
to touch to make this work right.
Attachment #128015 - Flags: review?(justdave)
(Assignee)

Comment 5

14 years ago
I am running this on our local bugzilla, with no negative effects so far (I
should have said I *did* test the patch). So I don't think any SQL problems
result from it.

If you take a look at the code in that area, you'll notice that selectcolumns
may very well have duplicate items: product and bug_status, for instance are in
displaycolumns, and *all* displaycolumns keys (except bug_id, which is removed
before) are added to selectcolumns. I don't think that's a problem; it seems
that Search.pm handles duplicate columns all right.

I think this fix is correct, and the impact to code is the lowest.

Comment 6

14 years ago
Comment on attachment 128015 [details] [diff] [review]
kiko_v1: add severity and priority to default query

Works ok here and looks ok.
Attachment #128015 - Flags: review+
(Assignee)

Updated

14 years ago
Flags: approval?
Flags: approval? → approval+
Attachment #128015 - Flags: review?(justdave)
Attachment #128015 - Flags: review?(jake)

Comment 7

14 years ago
*** Bug 118254 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 8

14 years ago
Checked into trunk.

Funny that Jeff offered the exact same patch, over one year ago. Our radar isn't
very sharp, or Jeff isn't bothering enough people :-)
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.