Closed Bug 213079 Opened 17 years ago Closed 17 years ago

When severity or priority are hidden, CSS class names are incomplete in buglist

Categories

(Bugzilla :: Query/Bug List, defect)

2.17.4
defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: kiko, Assigned: kiko)

References

Details

Attachments

(1 file)

When the severity or priority columns are hidden, CSS class names are incomplete
in buglist. Patch coming up
How does this look?
Attachment #128015 - Flags: review?(jake)
*** Bug 176526 has been marked as a duplicate of this bug. ***
Tobias, can you give the patch a spin?
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
Comment on attachment 128015 [details] [diff] [review]
kiko_v1: add severity and priority to default query

I want to research the impact of this a little...

I think you'll wind up with prority/severity twice if the user actually picked
it from their column list if you do this (and it'll probably cause an SQL error
under those circumstances).  I think there's more code in Search.pm you'll have
to touch to make this work right.
Attachment #128015 - Flags: review?(justdave)
I am running this on our local bugzilla, with no negative effects so far (I
should have said I *did* test the patch). So I don't think any SQL problems
result from it.

If you take a look at the code in that area, you'll notice that selectcolumns
may very well have duplicate items: product and bug_status, for instance are in
displaycolumns, and *all* displaycolumns keys (except bug_id, which is removed
before) are added to selectcolumns. I don't think that's a problem; it seems
that Search.pm handles duplicate columns all right.

I think this fix is correct, and the impact to code is the lowest.
Comment on attachment 128015 [details] [diff] [review]
kiko_v1: add severity and priority to default query

Works ok here and looks ok.
Attachment #128015 - Flags: review+
Flags: approval?
Flags: approval? → approval+
Attachment #128015 - Flags: review?(justdave)
Attachment #128015 - Flags: review?(jake)
*** Bug 118254 has been marked as a duplicate of this bug. ***
Checked into trunk.

Funny that Jeff offered the exact same patch, over one year ago. Our radar isn't
very sharp, or Jeff isn't bothering enough people :-)
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.