213079 - When severity or priority are hidden, CSS class names are incomplete in buglist

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Christian Reis]

When the severity or priority columns are hidden, CSS class names are incomplete
in buglist. Patch coming up

Comment 1

[Christian Reis]

Attachment: kiko_v1: add severity and priority to default query

How does this look?

Comment 2

[Tobias Burnus]

*** Bug 176526 has been marked as a duplicate of this bug. ***

Comment 3

[Christian Reis]

Tobias, can you give the patch a spin?

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 128015 [details] [diff] [review]
kiko_v1: add severity and priority to default query

I want to research the impact of this a little...

I think you'll wind up with prority/severity twice if the user actually picked
it from their column list if you do this (and it'll probably cause an SQL error
under those circumstances).  I think there's more code in Search.pm you'll have
to touch to make this work right.

Comment 5

[Christian Reis]

I am running this on our local bugzilla, with no negative effects so far (I
should have said I *did* test the patch). So I don't think any SQL problems
result from it.

If you take a look at the code in that area, you'll notice that selectcolumns
may very well have duplicate items: product and bug_status, for instance are in
displaycolumns, and *all* displaycolumns keys (except bug_id, which is removed
before) are added to selectcolumns. I don't think that's a problem; it seems
that Search.pm handles duplicate columns all right.

I think this fix is correct, and the impact to code is the lowest.

Comment 6

[Tobias Burnus]

Comment on attachment 128015 [details] [diff] [review]
kiko_v1: add severity and priority to default query

Works ok here and looks ok.

Comment 7

[Jeff Hedlund]

*** Bug 118254 has been marked as a duplicate of this bug. ***

Comment 8

[Christian Reis]

Checked into trunk.

Funny that Jeff offered the exact same patch, over one year ago. Our radar isn't
very sharp, or Jeff isn't bothering enough people :-)