Closed Bug 213085 Opened 17 years ago Closed 17 years ago

DBname_to_id($qa_contact) in importxml.pl

Categories

(Bugzilla :: Bug Import/Export & Moving, defect)

2.17.4
defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: gbugzilla, Assigned: justdave)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20030623
Build Identifier: 

in importxml.pl

      SendSQL("SELECT initialqacontact FROM components, products " .
              "WHERE components.product_id = products.id" .
              " AND products.name = " . SqlQuote($product[0]) .
              " AND components.name = " . SqlQuote($component[0]) );
      $qa_contact = FetchOneColumn();
      push (@values, SqlQuote(DBname_to_id($qa_contact)) );
      push (@query, "qa_contact");

Bad, bad DBname_to_id. initialqacontact IS and id.

Reproducible: Always

Steps to Reproduce:
confirmed on the tip.  oops.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → Bugzilla 2.18
Version: unspecified → 2.17.4
Attachment #128021 - Flags: review?(myk)
Comment on attachment 128021 [details] [diff] [review]
patch

r=myk Note also the unnecessary use of SqlQuote on line 584.
Attachment #128021 - Flags: review?(myk) → review+
Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.34; previous revision: 1.33
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: approval+
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.