213085 - DBname_to_id($qa_contact) in importxml.pl

Status: RESOLVED FIXED

(Bugzilla :: Bug Import/Export & Moving, defect)

Description

[tg]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20030623
Build Identifier: 

in importxml.pl

      SendSQL("SELECT initialqacontact FROM components, products " .
              "WHERE components.product_id = products.id" .
              " AND products.name = " . SqlQuote($product[0]) .
              " AND components.name = " . SqlQuote($component[0]) );
      $qa_contact = FetchOneColumn();
      push (@values, SqlQuote(DBname_to_id($qa_contact)) );
      push (@query, "qa_contact");

Bad, bad DBname_to_id. initialqacontact IS and id.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Dave Miller [:justdave]]

confirmed on the tip.  oops.

Comment 2

[Dave Miller [:justdave]]

Attachment: patch

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 128021 [details] [diff] [review]
patch

r=myk Note also the unnecessary use of SqlQuote on line 584.

Comment 4

[Dave Miller [:justdave]]

Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.34; previous revision: 1.33
done