213299 - missing character in source code

Status: VERIFIED DUPLICATE of bug 43267

(Core Graveyard :: View Source, defect)

Description

[Mateusz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624

when you display source code of the page given above you will see that line 280 is:
var status_image_1_1 = "<a href='JavaScript:void(0)'
OnClick='launch_support_1_1()'><img src="+phplive_image_1_1+" border=0
alt=\"Click for Live Support!\></a>" ;

but should be:

var status_image_1_1 = "<a href='JavaScript:void(0)'
OnClick='launch_support_1_1()'><img src="+phplive_image_1_1+" border=0
alt=\"Click for Live Support!\"></a>" ;

the difference is the quote mark (9th character from the end).
small thing but i've just lost 3 hours 2day to find out where's bug in my
software, byt the bug is on your side :)


Reproducible: Always

Steps to Reproduce:
1.go to http://chat.net-affinity.com/js_code.php?client_id=1&btn=1&dep_id=1
2.the same page using explorer
3.compare results of source code

Actual Results:  
you will see the difference (missing character)

Expected Results:  
correct this :)

Comment 1

[Jo Hermans]

It's caused by the "-->" string at line 44. This is illegal, because it will
close the entire comment, even when it was inside quotes.

This was also the reason of the funny color changes that were visible in View ->
Page Source. And it was also the reason of the mangled source-code that you saw
on the screen.

Solution: go to line 44, and change to
style += "-" + "->" ;

I don't know why it works in IE, but it failed in Safari too.

Comment 2

[Jason Barnabe (np)]

http://www.w3.org/TR/html4/intro/sgmltut.html#h-3.2.4

"Authors should avoid putting two or more adjacent hyphens inside comments."

Invalid. Reopen if you disagree.

Comment 3

[timeless]

personally i'd have marked it WONTFIX or DUPLICATE instead of INVALID.

the reason ie's source shows it is that ie's is a raw source. mozilla's is a
markup which follows the general parsing path which includes getting upset when
people do things which shouldn't be done.

Comment 4

[Jason Barnabe (np)]

Actually, I didn't notice that this was filed as a bug with ViewSource. Had it
been a "this page doesn't display properly", then yes that would be invalid (the
code is wrong).

Not showing up in View Source is probably a WONTFIX, but I'm not the one to
decide that. Reopening.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

I fixed this recently, marking as a DUPE.

*** This bug has been marked as a duplicate of 43267 ***