21333 - [DOGFOOD]regression msg content is doubled when viewing a message sent with Seamonkey

Status: VERIFIED DUPLICATE of bug 21189

(Core :: Layout, defect, P3)

Description

[esther]

Using mac build 1999120910M12 when you view a message that was sent by
seamonkey (i used this same build date) the text you typed is displayed twice.

1. Launch Messenger
2. Select New Msg button
3. Address the message to yourself and type in "this is a test" in the body and
Send.
4. Open the message

Result: On Mac only this message displays in the message pane as "this is a
test""this is a test".  This same message displayed on win & linux is OK.
Expected:  To see the message displayed as it was typed.

Comment 1

[lchiang]

Nominate for dogfood.

Comment 2

[pmock]

Changing qa assigned to [e-mail]

Comment 3

[leger]

Putting on PDT+ radar.

Comment 4

[rhp (gone)]

JF, this may be for me...let me know if you need some help.

- rhp

Comment 5

[Jean-Francois Ducarroz]

Start looking at it right now...

Comment 6

[Jean-Francois Ducarroz]

Ok, it's really just a display message matter. I have the same problem on window
but instead of having the whole test duplicated, I have only few extra
random characters at the end. I look at the date in the mailbox file itself (the
Berkley one) and everything is fine.

Comment 7

[Jean-Francois Ducarroz]

That appends also when you send an HTML message from 4.x.

When I send the following message:
Line 1 <cr>
Line 2 <no CR>
<vcard inserted here>

When I display the message on Mac, I get:
Line 1 Line 1
Line 2 Line 2
<vcard>

Comment 8

[Jean-Francois Ducarroz]

I've debug the code until nsMimeXULEmitter::DumpBody. The body still correct but
then we convert it to Base64 and at this point I don't know it the encoded
string still good or if we have problem later when we decode the data. I have
the feeling this bug is a regression of bug 16672.

Comment 9

[Jean-Francois Ducarroz]

I have a small test case that reproduce the problem. It's a simple xul file which declare an iframe which the source
is a Base64 string. Normally, the frame should display "Hello world" once only.

Comment 10

[Jean-Francois Ducarroz]

Attachment: Test case to reproduce the problem

Comment 11

[Jean-Francois Ducarroz]

How to use the test case? just open the file into the browser...

Comment 12

[rhp (gone)]

*** Bug 21314 has been marked as a duplicate of this bug. ***

Comment 13

[rhp (gone)]

Attachment: This LARGE email will crash during layout

Comment 14

[lchiang]

My bug on Win32 was marked a duplicate of this.  I'm correcting the platform
fields and summary.  To QA: when verifying, also check case in my duplicate bug.

Comment 15

[Jean-Francois Ducarroz]

I found a problem with the way we compute the size of the decoded string in
nsDataChannel.cpp. That doesn't fix the duplication of the content of each lines
in Mac but that remove any garbage characters we see often on all platform:

Index: nsDataChannel.cpp
===================================================================
RCS file: /cvsroot/mozilla/netwerk/protocol/data/src/nsDataChannel.cpp,v
retrieving revision 1.17
diff -r1.17 nsDataChannel.cpp
178,179d177
<         char *decodedData = (char*)nsAllocator::Alloc((dataLen * 3)/4);
<         if (!decodedData) return NS_ERROR_OUT_OF_MEMORY;
181c179,180
<         decodedData = PL_Base64Decode(comma+1, dataLen, decodedData);
---
>         char * decodedData = PL_Base64Decode(comma+1, dataLen, nsnull);
>         if (!decodedData) return NS_ERROR_OUT_OF_MEMORY;
183c182
<         dataToWrite->dataLen = (dataLen * 3)/4;
---
>         dataToWrite->dataLen = PL_strlen(decodedData);
186c185
<         rv = bufOutStream->WriteSegments(nsReadData, dataToWrite, (dataLen *
3)/4, &wrote);
---
>         rv = bufOutStream->WriteSegments(nsReadData, dataToWrite,
dataToWrite->dataLen, &wrote);

Comment 16

[troy]

The Mac specific problem of content being displayed is a DUP of 21189.

It seems there is another problem that was added to this bug report. If so,
please create a separate bug report

*** This bug has been marked as a duplicate of 21189 ***

Comment 17

[Jean-Francois Ducarroz]

I will reopen bug 21314 for the carbage characters.

Comment 18

[lchiang]

Peter, the bug that this a duplicate of has been marked fixed on 12/10.  Please
verify the Mac case in this bug report using Monday's builds.  Thanks.

Comment 19

[pmock]

Verified as fixed on mac commercial seamonkey build.  I was testing under IMAP
with the following build:
ftp://sweetlou/products/client/seamonkey/macos/8.x/ppc/1999-12-11-08-M12/NSMacIn
staller-M12.sea.bin