Closed
Bug 213347
Opened 22 years ago
Closed 22 years ago
[FIX] Avoid calling HasAttr in AddAttributes
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: perf)
Attachments
(2 files)
|
5.85 KB,
patch
|
Details | Diff | Splinter Review | |
|
4.58 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Loop reversal happiness
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Comment 2•22 years ago
|
||
|
|
Assignee | |
Comment 3•22 years ago
|
||
Comment on attachment 128203 [details] [diff] [review]
Same as -w; for review only. Do NOT check in.
jst, could you review?
Attachment #128203 -
Flags: superreview?(jst)
Attachment #128203 -
Flags: review?(jst)
|
||
Comment 4•22 years ago
|
||
Comment on attachment 128203 [details] [diff] [review]
Same as -w; for review only. Do NOT check in.
Nice! :-)
r+sr=jst
Attachment #128203 -
Flags: superreview?(jst)
Attachment #128203 -
Flags: superreview+
Attachment #128203 -
Flags: review?(jst)
Attachment #128203 -
Flags: review+
|
|
Assignee | |
Comment 5•22 years ago
|
||
Checked in, though no obvious effect on Tp....
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
This caused bug 214077.
(Although it's not really this patch's fault, since this patch also fixed the
equivalent testcase that had the attributes listed in the reverse order.)
|
|
Assignee | |
Comment 8•22 years ago
|
||
This also caused bug 234675
You need to log in
before you can comment on or make changes to this bug.
Description
•