213494 - Array elements displayed out of sequence when array is expanded

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Rick Alther]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

Arrays (including JavaArrays) with more than 10 elements do not display in
sequence when the array is expanded in the Local Variables window.

e.g. if I have an Array of 15 elements and I expand the Array in the Local
Variables window to see each element, they are listed in the following order:
0, 1, 10, 11, 12, 13, 14, 15, 2, 3, 4, 5, 6, 7, 8, 9.

They are being sorted alphabetically instead of numerically.

Reproducible: Always

Steps to Reproduce:
1. Open Venkman.
2. Open a URL/Page/Script which uses Arrays.
3. Make sure the Array contains at least 10 elements in order to see the problem.
4. Put a break point somewhere to view the contents of the Array.  
5. Run the script.  When the breakpoint is hit, examine the Array in the Local
Variables window and expand it.  Notice the elements are not in numerical
sequence, but in alphabetical sequence.

Actual Results:  
The contents of the Array are displayed in alphabetical sequence which is incorrect.

Expected Results:  
Display the contents of the Array in numerical sequence.

Currently using Venkman 0.9.77

Comment 1

[Rick Alther]

Attachment: Screen shot of Local Variables window displaying problem.

Screen shot shows the Local Variables window with a JavaArray expanded showing
the elements being displayed out of sequence.

Comment 2

[James Ross]

Attachment: Sort using blocks

The sorting function may seem a bit odd - it is - but it definately produces the most naturally sorted results. :)

E.g.:
  1foo1
  1foo2
  1foo10
  1foo11
  2foo1
  2foo2
  2foo10
  2foo11
  10foo1
  10foo2
  10foo10
  10foo11
  11foo1
  11foo2
  11foo10
  11foo11

Comment 3

[James Ross]

Comment on attachment 220874 [details] [diff] [review]
Sort using blocks

Here's a 3.5yo patch, enjoy.

Comment 4

[:Gijs (he/him)]

Comment on attachment 220874 [details] [diff] [review]
Sort using blocks

Great, thanks a lot! r=me :-)

Comment 5

[:Gijs (he/him)]

I finally pushed this to HG: 653:ab37d914e678