21410 - [feature] Color picker does not work for background/foreground color settings

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[bijals (gone)]

Steps:
1) Open Composer
2) Click on the color picker for foreground or background
3) Pick a color

Actual Results: Nothing happens

Expected Results: Font color or background color changes

Build Date/Platform: WinNT 1999120915

Comment 1

[bijals (gone)]

Charley indicated that this is not an Ender issue, but a layout issue.  I
created this bug to track this issue.

Comment 2

[Charles Manske]

Color pickers in general don't work, but there is editor-specific work
that needs to be done.

Comment 3

[sujay]

also fix the color picker in editor prefs....busted there also....

Comment 4

[rubydoo123]

updating summary fields, removing PDT- & [dogfood], adding [feature]

Comment 5

[Charles Manske]

While I still need to implement some code in Composer, this won't work at all
unless the onclick handler is called for the color picker (bug 23740).

Comment 6

[Charles Manske]

Editor-related fixes are in, but it still doesn't work because of bug 23739

Comment 7

[Charles Manske]

Editor part is fixed, but blocked by 23739. Since that bug isn't marked as
M13, I'm moving this to M14.

Comment 8

[Charles Manske]

This is fixed, but cannot be verified until bug 23739 is fixed.

Comment 9

[sujay]

will verify after 23739 is fixed

Comment 10

[sujay]

reopening...color picker still not operational using 2/4 builds.. even after
23739 fix.

reopening for re-examination.

Comment 11

[Charles Manske]

Yep, accidently broken as side effect of other changes. Fix is ready.

Comment 12

[Charles Manske]

Fix is ready for this, so don't move to M15

Comment 13

[Charles Manske]

Removing incorrect status whiteboard message

Comment 14

[Charles Manske]

Checked in 2/9

Comment 15

[sujay]

this is no where near being fixed...used 2/10 builds..

color picker doesn't work at all....

Comment 16

[sujay]

yeah even using today's 2/11 build here are the problems:

1) you can highlight text, and change the color, but then
your document is hosed with whatever color you selected. Its
a serious visual issue...also the entire line of text changes
to that color.

also the top functional part of the color picker doesn't work....its basically
two functional pieces in one pull-down right...

I still feel the color picker is seriously impaired....Charley, come
by my cube when you're in the office..I'll show you what I'm seeing.

Comment 17

[Charles Manske]

I'm at home, so I need more detailed info:
The color picker widget on the toolbar has 2 buttons that are overlapping to
look just like widgets in graphics programs. The upper left button is for text
and when you click on it you should see the picker popup with "Text Color" as
the caption. The button on the lower right (slightly behind the other) is
for bacground and when clicked should show the popup with "Background Color"
as a caption. What I see is that setting text color works if you have a text
selection -- it doesn't work at the caret (it should affect the next text you
type, but doesn't). When you change background color in a page, the color is
set only behind the line with the text and a block which is where the picker
window was. This is a layout bug (11491) which I wish would get escalated.

Comment 18

[sujay]

bingo....thanks charley....I guess if you factor out bug 11491, then its
working....so that issue is covered in a separate bug...I tried looking
for the issue...thanks

mark this fixed please...I'll mark it verifed....

Comment 19

[Charles Manske]

Ok, we won't hold up this for long-standing background painting problem.

Comment 20

[sujay]

verified once and for all in 2/11 build...whew!