21411 - [DOGFOOD][REGRESSION] Selections in addr picker don't make it to compose window.

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[laurel]

Using 12-10-08m12 commerical builds on linux 6.0, mac Os 8.5.1 and NT 4.0

Using the address picker doesn't work; the names selected as addressees don't
appear in compose window address line(s) upon OK form the address picker dialog.

1.  Launch to messenger window.
    Click New Msg.
    Click the address button in compose window which brings up the address
picker dialog.
2.  In address picker dialog, select a name from the address book and click To:
button which places the selected recipient into the address bucket portion of
the address picker window.
    Confirm OK from address picker.

Result:  back in the compose window, the recipient line(s) is blank.

Expected:  the selected recipient(s) from address picker should display
respectively in an address line in the compose window.

Comment 1

[hangas]

JF?

Comment 2

[Jean-Francois Ducarroz]

No idea yet, still working on other PDT+ bug.

Comment 3

[lchiang]

I believe this used to work before. Regression.

Comment 4

[lchiang]

*** Bug 21454 has been marked as a duplicate of this bug. ***

Comment 5

[Jean-Francois Ducarroz]

I am looking at it right now...

Comment 6

[Jean-Francois Ducarroz]

here is the fix:

Index: abSelectAddressesDialog.js
===================================================================
RCS file: /cvsroot/mozilla/mailnews/addrbook/resources/content/abSelectAddressesDialog.js,v
retrieving revision 1.9
diff -r1.9 abSelectAddressesDialog.js
70c70
<
---
>
80c80,81
< 				if ( cell.childNodes &&  cell.childNodes.length )
---
> 				text = cell.getAttribute('value');
> 				if ( text )
82,83c83
< 					text = cell.getAttribute('value');
< 					if ( text )
---
> 					switch ( text[0] )
85,102c85,99
< 						switch ( text[0] )
< 						{
< 							case prefixTo[0]:
< 								if ( toAddress )
< 									toAddress += ", ";
< 								toAddress += text.substring(prefixTo.length, text.length);
< 								break;
< 							case prefixCc[0]:
< 								if ( ccAddress )
< 									ccAddress += ", ";
< 								ccAddress += text.substring(prefixCc.length, text.length);
< 								break;
< 							case prefixBcc[0]:
< 								if ( bccAddress )
< 									bccAddress += ", ";
< 								bccAddress += text.substring(prefixBcc.length, text.length);
< 								break;
< 						}
---
> 						case prefixTo[0]:
> 							if ( toAddress )
> 								toAddress += ", ";
> 							toAddress += text.substring(prefixTo.length, text.length);
> 							break;
> 						case prefixCc[0]:
> 							if ( ccAddress )
> 								ccAddress += ", ";
> 							ccAddress += text.substring(prefixCc.length, text.length);
> 							break;
> 						case prefixBcc[0]:
> 							if ( bccAddress )
> 								bccAddress += ", ";
> 							bccAddress += text.substring(prefixBcc.length, text.length);
> 							break;
108c105
<
---
>

Comment 7

[Jean-Francois Ducarroz]

Will check it in if it become a PTD+/- bug only.

Comment 8

[Jim Roskind]

Set to - and moved to M13

Comment 9

[lchiang]

so the address picker will be useless for M12?

Comment 10

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 11

[esther]

Using build 1999121309m12 on win98 and build 1999121308 on mac and linux, this
is fixed.  Verified