214530 - Need Way to Create Bookmarks From Pages.

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

For Netscape 6, Mozilla added functionality that let pages call an "Add Sidebar
Panel" function to add panels to the GUI. Proposing an analog for Bookmarks,
parameterized to let the page specifiy things like keywords. This supports a
mechanism for creating bookmark keywords easily, e.g. a site can offer access to
its catalog direct from the browser by encouraging the user to add keyword
bookmarks.

Comment 1

[Jesse Ruderman]

*** This bug has been marked as a duplicate of 66248 ***

Comment 2

[Mike Connor [:mconnor]]

reopening..

Comment 3

[Jesse Ruderman]

In bug 66248, I was opposed to adding this feature because porn sites abuse it
in IE.  We could prevent this abuse by using the pop-up window restrictions
(onclick is ok, onload is not, etc) for bringing up the add-bookmark dialog.

Comment 4

[Mike Connor [:mconnor]]

I agree, this needs to be user-initiated or it will be abused.  Obviously we
need to protect users from certain things, but I see a lot of value in this for
users and for commercial sites as well.  I was going to mention this earlier,
but sleep deprivation kicked in soon after I reopened this.

Comment 5

[Ben Bucksch (:BenB)]

You can easily circumvent the pop-up window restrictions. Users visting porn
sites will click on a link there as well.

It's a dup.

*** This bug has been marked as a duplicate of 66248 ***

Comment 6

[noririty]

Firebird != Seamonkey

This feature is very important and actually needed for firebird.

Comment 7

[noririty]

.

Comment 8

[Mike Connor [:mconnor]]

Ben, this is something that is planned for Firebird to work with the new Web
Panels sidebar among other things.  Duping this against a WONTFIXed bug from
Seamonkey doesn't really prove or accomplish anything.

As this is a design decision and a feature needed for Firebird, not for Mozilla,
the previous bug and its WONTFIX don't really apply here.  If you want to take
this up with Ben Goodger regarding HOW it will be implemented (i.e. so it can be
disabled by default in Beonex Communicator or even for every other mozilla.org
product) please do so, but please leave Firebird decisions to Firebird developers.

Comment 9

[Ben Bucksch (:BenB)]

The (good) arguments mentioned for Seamonkey are generic and apply just as well
to Firebird. We cannot go through ever single controversial decision again.

I have yet to hear good arguments, why Firebird is so different in this case,
arguments which would outweight the arguments against this feature. "to work
with the new Web Panels sidebar among other things" is not at all clear. Also,
is there no other way to achieve the desired result?

Comment 10

[Mike Connor [:mconnor]]

Ben, the Web Panels sidebar now supports targeting links to the sidebar panel
rather than main content.  i.e. I can now bookmark the Bugzilla sidebar to open
in the Web Panels sidebar, and have the link on my toolbar, the existing
functionality to add sidebars doesn't support this, and doesn't work as a
bookmark.  We need a method to support creation of these shortcuts automatically
to make it a user-accessible feature.  Allowing a keyword parameter also would
be helpful, as sites like IMDB could use something like this to possibly drive
more traffic to their site, and this is another usability win.  People might not
go through manually creating an IMDB keyword search, but would add it if it was
as simple as clicking a link.

Sure, there are other ways, but they're not as accessible.  My dad couldn't or
wouldn't create a keyword search manually, but might use this if he could click
a link to add it.  This isn't a generic addBookmark in the IE sense, we don't
need that, and wouldn't necessarily be compatible with IE's implementation.  And
if its only accessible on click (none of the popup workarounds like onmouseover
should apply here) and has a confirmation, the only risk is mislabelled links
annoying users, which I think would be a minimal problem (most addBookmark links
in the wild are onload/onunload, from my experience with IE).

I'm not a fan of rehashing old issues, but this is implementing a more robust
and better controlled system than any of the old proposals even hinted at. 
There's plenty of ways to add a generic bookmark, we don't JS to do that.  But
allowing special bookmarks to be created (keywords and web panels) is needed to
make the features take hold.

Comment 11

[Mike Connor [:mconnor]]

rel="keyword" for keyword bookmarks? or just rel="bookmark"?

Comment 12

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 21

[Marco Bonardo [:mak]]

i don't think this is a wontfix, it is just that we allow pages to add a sidebar bookmark, but we don't allow them to add a bookmark... so we need at least to clarify what we want to do.

Comment 22

[:Gavin Sharp [email: [e-mail]]]

I think bookmarks are probably the wrong thing to be encouraging at this point.