214558 - unnecessary output from checksetup.pl "which: no interdiff in (/usr/bin:/bin)"

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Dave Miller [:justdave]]

I get the following once an hour from landfill.  interdiff is in /usr/local/bin,
which as you can see is not in the PATH when checksetup.pl is run from cron.  It
shouldn't be looking for it if localconfig already has a value set for it (which
it does).

Date: Wed, 30 Jul 2003 21:00:42 -0700
From: [e-mail] (Cron Daemon)
To: [e-mail]
Subject: Cron <root@landfill> /etc/bugzilla/bugzilla-updater
/var/www/html/bugzilla-tip HEAD
X-Cron-Env: <SHELL=/bin/sh>
X-Cron-Env: <HOME=/root>
X-Cron-Env: <PATH=/usr/bin:/bin>
X-Cron-Env: <LOGNAME=root>

which: no interdiff in (/usr/bin:/bin)

Comment 1

[John Keiser (jkeiser)]

Attachment: Patch

This patch fixes the problem by checking if the variable exists *before*
running which.

Comment 2

[John Keiser (jkeiser)]

BTW: the way I reproduced it was to set $ENV{'PATH'} = '/bin:/usr/bin:.'; at the
top of checksetup.pl before and after my patch.  interdiff complained before and
did not complain after.  Oddly, this was the case even though I set interdiff in
localconfig to ''.

Comment 3

[John Keiser (jkeiser)]

Attachment: Patch v1.1

This version fixes a couple of other general things justdave noticed: if we're
on Win32, we shouldn't run 'which'; and in the case of an error, the output of
'which' returns blank because 'no mysql' is on stderr, not stdout.

Comment 4

[John Keiser (jkeiser)]

Attachment: Patch v1.2

After reading bug 208521 and thinking about it, the Win32 stuff in this patch
would not work in cygwin nor does it provide reasonable defaults for Windows. 
So I have removed that part of the patch and left the error-checking and
LocalVarExists() checks in.

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 128956 [details] [diff] [review]
Patch v1.2

it works

Comment 6

[John Keiser (jkeiser)]

Fix checked in