215208 - Descriptions in view activity bug still in english

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Oscar Manuel Gómez Senovilla]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.4) Gecko/20030625
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.4) Gecko/20030625

In 2.17.4, clicking to view the activity bug, there isn't a map for activities
and related material for getting it translated.

I'm working on a way to fix it, but I think it will take me some time, unless
somebody wants to take it right away.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Oscar Manuel Gómez Senovilla]

Setting dependency for general bug 214907

Comment 2

[Dave Miller [:justdave]]

It's easier to fix than you think. :)

The global/field-descs.none.tmpl file already has all the translations.  We just
need to use those instead of depending on fielddefs.  The English description in
the fielddefs table should ideally go away.

I was about to file this myself because we discovered it in Zippy's Bugzilla
this last week trying to rename a field.  Yet another place to change the field
description.

Comment 3

[Oscar Manuel Gómez Senovilla]

Not having tried ALL possibilities for what/added/removed, but having taken all
the fieldids in field-descs.none.tmpl (apart from reusing, by the moment, the
resolution and bug statuses). I have first added the field-descs.none.tmpl file
to be processed. Then "extracted" the commented values to map them with the
descriptions in the template, which is worth a look to bug that handles the
field-descs.none.tmpl.

Here's my full es/default/bug/activity.html.tmpl (excluding initial mozilla.org
comments):



[% PROCESS bug/time.html.tmpl %]

[% PROCESS "global/field-descs.none.tmpl" %]

[% IF incomplete_data %]
  <p>
    Anteriormente hubo un bug que ten&iacute;a como efecto que Bugzilla perdiera
    los datos de actividad cuando hab&iacute;a un gran n&uacute;mero de cc o
dependencias.
    Eso ya se solucion&oacute;, pero hubo algunos datos que no pudieron ser
regenerados.
    Los cambios que el script no pudo determinar fielmente van precedidos con el
    s&iacute;mbolo '?'.
  </p>
[% END %]

[% IF operations.size > 0 %]
  <table border cellpadding="4">
    <tr>
      <th>Qui&eacute;n</th>
      <th>Cu&aacute;ndo</th>
      <th>Qu&eacute;</th>
      <th>Borrado</th>
      <th>A&ntilde;adido</th>
    </tr>

    [% FOREACH operation = operations %]
      <tr>
        <td rowspan="[% operation.changes.size %]" valign="top">
          [% operation.who %]
        </td>
        <td rowspan="[% operation.changes.size %]" valign="top">
          [% operation.when FILTER time %]
        </td>
        [% FOREACH change = operation.changes %]
          [% "</tr><tr>" IF loop.index > 0 %]
            <td>
              [% IF change.attachid %]
                <a href="attachment.cgi?id=[% change.attachid %]&amp;action=view">
                Adjunto n&ordm;[% change.attachid %]</a>
              [% END %]
           [%# Here "item" it's just a temporary variable for translation
# that, if has been defined, uses the defined value, else, the original %]
              [% item=change.field %]
              [% IF activity_descs.$item == "" %]
                [% change.field %]
              [% ELSE %]
                [% activity_descs.$item %]
              [% END %]
            </td>
            <td>
              [% IF change.removed %]
                [% IF change.fieldname == 'estimated_time' ||
                      change.fieldname == 'remaining_time' ||
                      change.fieldname == 'work_time' %]
                  [% PROCESS formattimeunit time_unit=change.removed %]
                [% ELSE %]
[%# Here, assign to temp the value for later centralization, because it's
  # supposed to do the same as the latter change.added, and so they both
  # use the same name, "temp", which I claim for style correction %]
                  [% PROCESS showthing temp = change.removed %]
                [% END %]
              [% ELSE %]
                &nbsp;
              [% END %]
            </td>
            <td>
              [% IF change.added %]
                [% IF change.fieldname == 'estimated_time' ||
                      change.fieldname == 'remaining_time' ||
                      change.fieldname == 'work_time' %]
                  [% PROCESS formattimeunit time_unit=change.added %]
                [% ELSE %]
[%# This "temp" is explained before %]
                  [% PROCESS showthing temp = change.added %]
                [% END %]
              [% ELSE %]
                &nbsp;
              [% END %]
            </td>
        [% END %]
      </tr>
    [% END %]
  </table>
[% END %]

[%# Claim for correcting style for "showthing" %]
[% BLOCK showthing %]

  [% SWITCH change.field %]
    [%# If it's an "Status", "Resolution", process the already translated in
field-descs.none.tmpl %]
  [% CASE "Status" %]
    [% bug_status_descs.$temp FILTER html %]
  [% CASE "Resolution" %]
    [% resolution_descs.$temp FILTER html %]
  [% CASE %]
       [%# Any other, if defined as activity (taken from fieldid table) or
translated, take that. Else, just use the incoming temp variable %]
    [% IF activity_descs.$temp == "" %]
      [% temp FILTER html %]
    [% ELSE %]
      [% activity_descs.$temp %]
    [% END %]
  [% END %]


[% END %]

Comment 4

[Max Kanat-Alexander]

This bug has not been touched by its owner in over six months, even though it is
targeted to 2.20, for which the freeze is 10 days away. Unsetting the target
milestone, on the assumption that nobody is actually working on it or has any
plans to soon.

If you are the owner, and you plan to work on the bug, please give it a real
target milestone. If you are the owner, and you do *not* plan to work on it,
please reassign it to [e-mail] or a .bugs component owner. If you are
*anybody*, and you get this comment, and *you* plan to work on the bug, please
reassign it to yourself if you have the ability.

Comment 5

[Emmanuel Seyman]

Attachment: use localised statuses and resolutions

Adapt bug/activity/table.html.tmpl to use localised statuses and resolutions

Comment 6

[Emmanuel Seyman]

Attachment: add HTML filters

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 183396 [details] [diff] [review]
add HTML filters

Looks good. r=myk

Comment 8

[Emmanuel Seyman]

This kind of goes along with bug #215346.
Requesting approval.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Good low-risk polish fix for 2.20. a=myk

Comment 10

[Frédéric Buclin]

Checking in template/en/default/bug/activity/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/activity/table.html.tmpl,v
 <--  table.html.tmpl
new revision: 1.9; previous revision: 1.8
done